From bc01c71cd1e05ada005a391840d37095962178ec Mon Sep 17 00:00:00 2001 From: Raghunandan Balachandran Date: Fri, 7 Feb 2020 11:43:44 +0100 Subject: [PATCH] Fix PR comments --- docker-compose.yaml | 2 +- .../components/CreateEntityFormPage/CreateEntityFormPage.tsx | 2 +- .../src/components/CreateEntityPage/CreateEntityPage.test.tsx | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/docker-compose.yaml b/docker-compose.yaml index 765c9a32b5..ddde99b79a 100755 --- a/docker-compose.yaml +++ b/docker-compose.yaml @@ -49,6 +49,6 @@ services: service: scaffolder restart: unless-stopped volumes: - - ./backend/scaffolder/templates:/app/templates + - ./backend/scaffolder/templates:/app/templates:ro env_file: secrets.env diff --git a/frontend/packages/plugins/create-entity/src/components/CreateEntityFormPage/CreateEntityFormPage.tsx b/frontend/packages/plugins/create-entity/src/components/CreateEntityFormPage/CreateEntityFormPage.tsx index 0720523471..6482aff6bf 100644 --- a/frontend/packages/plugins/create-entity/src/components/CreateEntityFormPage/CreateEntityFormPage.tsx +++ b/frontend/packages/plugins/create-entity/src/components/CreateEntityFormPage/CreateEntityFormPage.tsx @@ -6,7 +6,7 @@ import { InfoCard } from '@backstage/core'; const useStyles = makeStyles(theme => ({ formGroup: { - padding: '10px', + padding: theme.spacing(2), }, })); diff --git a/frontend/packages/plugins/create-entity/src/components/CreateEntityPage/CreateEntityPage.test.tsx b/frontend/packages/plugins/create-entity/src/components/CreateEntityPage/CreateEntityPage.test.tsx index 6f45cef9cb..5e84fa9a51 100644 --- a/frontend/packages/plugins/create-entity/src/components/CreateEntityPage/CreateEntityPage.test.tsx +++ b/frontend/packages/plugins/create-entity/src/components/CreateEntityPage/CreateEntityPage.test.tsx @@ -5,6 +5,8 @@ import CreateEntityPage from './CreateEntityPage'; describe('CreateEntityPage', () => { it('should render', () => { const rendered = render(); - expect(rendered.getByText('Hello!')).toBeInTheDocument(); + expect( + rendered.getByText('Create New', { exact: false }), + ).toBeInTheDocument(); }); });