From bb95aca5aae5f2b43ab448b231546fcfd9725144 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Thu, 28 Apr 2022 14:03:55 +0200
Subject: [PATCH] scaffolder: extract DryRunResultsSplitView

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .../DryRunResults/DryRunResultsSplitView.tsx  | 55 ++++++++++++++++++
 .../TemplateEditorDryRunResults.tsx           | 57 +++----------------
 2 files changed, 63 insertions(+), 49 deletions(-)
 create mode 100644 plugins/scaffolder/src/components/TemplateEditorPage/TemplateEditor/DryRunResults/DryRunResultsSplitView.tsx

diff --git a/plugins/scaffolder/src/components/TemplateEditorPage/TemplateEditor/DryRunResults/DryRunResultsSplitView.tsx b/plugins/scaffolder/src/components/TemplateEditorPage/TemplateEditor/DryRunResults/DryRunResultsSplitView.tsx
new file mode 100644
index 0000000000..b554a1c0c0
--- /dev/null
+++ b/plugins/scaffolder/src/components/TemplateEditorPage/TemplateEditor/DryRunResults/DryRunResultsSplitView.tsx
@@ -0,0 +1,55 @@
+/*
+ * Copyright 2022 The Backstage Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { makeStyles } from '@material-ui/core/styles';
+import Divider from '@material-ui/core/Divider';
+import React, { Children, ReactNode } from 'react';
+import classNames from 'classnames';
+
+const useStyles = makeStyles(theme => ({
+  root: {
+    display: 'grid',
+    gridTemplateColumns: '280px auto 3fr',
+    gridTemplateRows: '1fr',
+  },
+  child: {
+    overflowY: 'auto',
+    height: '100%',
+    minHeight: 0,
+  },
+  firstChild: {
+    background: theme.palette.background.paper,
+  },
+}));
+
+export function DryRunResultsSplitView(props: { children: ReactNode }) {
+  const classes = useStyles();
+  const childArray = Children.toArray(props.children);
+
+  if (childArray.length !== 2) {
+    throw new Error('must have exactly 2 children');
+  }
+
+  return (
+    <div className={classes.root}>
+      <div className={classNames(classes.child, classes.firstChild)}>
+        {childArray[0]}
+      </div>
+      <Divider orientation="horizontal" />
+      <div className={classes.child}>{childArray[1]}</div>
+    </div>
+  );
+}
diff --git a/plugins/scaffolder/src/components/TemplateEditorPage/TemplateEditor/DryRunResults/TemplateEditorDryRunResults.tsx b/plugins/scaffolder/src/components/TemplateEditorPage/TemplateEditor/DryRunResults/TemplateEditorDryRunResults.tsx
index 84ef1fc73c..5a429a3cc1 100644
--- a/plugins/scaffolder/src/components/TemplateEditorPage/TemplateEditor/DryRunResults/TemplateEditorDryRunResults.tsx
+++ b/plugins/scaffolder/src/components/TemplateEditorPage/TemplateEditor/DryRunResults/TemplateEditorDryRunResults.tsx
@@ -28,14 +28,7 @@ import Typography from '@material-ui/core/Typography';
 import Tabs from '@material-ui/core/Tabs';
 import Tab from '@material-ui/core/Tab';
 import Box from '@material-ui/core/Box';
-import React, {
-  Children,
-  ReactNode,
-  useEffect,
-  useMemo,
-  useState,
-} from 'react';
-import classNames from 'classnames';
+import React, { useEffect, useMemo, useState } from 'react';
 import { useDryRun } from '../DryRunContext';
 import DeleteIcon from '@material-ui/icons/Delete';
 import CheckIcon from '@material-ui/icons/Check';
@@ -51,6 +44,7 @@ import { TaskStatusStepper } from '../../../TaskPage/TaskPage';
 import { TaskPageLinks } from '../../../TaskPage/TaskPageLinks';
 import ListItemIcon from '@material-ui/core/ListItemIcon';
 import { BackstageTheme } from '@backstage/theme';
+import { DryRunResultsSplitView } from './DryRunResultsSplitView';
 
 const useStyles = makeStyles((theme: BackstageTheme) => ({
   accordionHeader: {
@@ -219,41 +213,6 @@ function ResultView() {
   );
 }
 
-const useSplitViewStyles = makeStyles(theme => ({
-  root: {
-    display: 'grid',
-    gridTemplateColumns: '280px auto 3fr',
-    gridTemplateRows: '1fr',
-  },
-  child: {
-    overflowY: 'auto',
-    height: '100%',
-    minHeight: 0,
-  },
-  childPaper: {
-    background: theme.palette.background.paper,
-  },
-}));
-
-function SplitView(props: { children: ReactNode }) {
-  const classes = useSplitViewStyles();
-  const childArray = Children.toArray(props.children);
-
-  if (childArray.length !== 2) {
-    throw new Error('SplitView must have exactly 2 children');
-  }
-
-  return (
-    <div className={classes.root}>
-      <div className={classNames(classes.child, classes.childPaper)}>
-        {childArray[0]}
-      </div>
-      <Divider orientation="horizontal" />
-      <div className={classes.child}>{childArray[1]}</div>
-    </div>
-  );
-}
-
 function FilesContent() {
   const classes = useStyles();
   const { selectedResult } = useDryRun();
@@ -278,7 +237,7 @@ function FilesContent() {
     return null;
   }
   return (
-    <SplitView>
+    <DryRunResultsSplitView>
       <FileBrowser
         selected={selectedPath}
         onSelect={setSelectedPath}
@@ -294,7 +253,7 @@ function FilesContent() {
           selectedFile?.base64Content ? atob(selectedFile.base64Content) : ''
         }
       />
-    </SplitView>
+    </DryRunResultsSplitView>
   );
 }
 function LogContent() {
@@ -325,14 +284,14 @@ function LogContent() {
   const selectedStep = steps.find(s => s.id === currentStepId) ?? steps[0];
 
   return (
-    <SplitView>
+    <DryRunResultsSplitView>
       <TaskStatusStepper
         steps={steps}
         currentStepId={selectedStep.id}
         onUserStepChange={setUserSelectedStepId}
       />
       <LogViewer text={selectedStep?.logString ?? ''} />
-    </SplitView>
+    </DryRunResultsSplitView>
   );
 }
 
@@ -345,7 +304,7 @@ function OutputContent() {
   }
 
   return (
-    <SplitView>
+    <DryRunResultsSplitView>
       <Box pt={2}>
         {selectedResult.output?.links?.length && (
           <TaskPageLinks output={selectedResult.output} />
@@ -359,6 +318,6 @@ function OutputContent() {
         readOnly
         value={JSON.stringify(selectedResult.output, null, 2)}
       />
-    </SplitView>
+    </DryRunResultsSplitView>
   );
 }