From bb7430dababac68b9f4989aa5933b2157408f3d6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Marschollek?= <bjoern.marschollek@personio.de>
Date: Fri, 4 Sep 2020 13:56:42 +0200
Subject: [PATCH] Refactor the Sentry plugin router

---
 plugins/sentry/src/components/Router.tsx | 31 +++++++++++-------------
 1 file changed, 14 insertions(+), 17 deletions(-)

diff --git a/plugins/sentry/src/components/Router.tsx b/plugins/sentry/src/components/Router.tsx
index 7c0468fda2..47d532b4e3 100644
--- a/plugins/sentry/src/components/Router.tsx
+++ b/plugins/sentry/src/components/Router.tsx
@@ -19,31 +19,28 @@ import { Routes, Route } from 'react-router';
 import { WarningPanel } from '@backstage/core';
 import { SentryPluginWidget } from './SentryPluginWidget/SentryPluginWidget';
 
-const SENTRY_ANNOTATION = 'sentry.io/project-id';
+const SENTRY_ANNOTATION = 'sentry.io/project-slug';
 
-const isPluginApplicableToEntity = (entity: Entity) =>
-  Boolean(entity.metadata.annotations?.[SENTRY_ANNOTATION]) &&
-  entity.metadata.annotations?.[SENTRY_ANNOTATION] !== '';
+export const Router = ({ entity }: { entity: Entity }) => {
+  const projectId = entity.metadata.annotations?.[SENTRY_ANNOTATION];
 
-export const Router = ({ entity }: { entity: Entity }) =>
-  !isPluginApplicableToEntity(entity) ? (
-    <WarningPanel title="Sentry plugin:">
-      `entity.metadata.annotations['
-      {SENTRY_ANNOTATION}']` key is missing on the entity.{' '}
-    </WarningPanel>
-  ) : (
+  if (!projectId) {
+    return (
+      <WarningPanel title="Sentry plugin:">
+        <pre>{SENTRY_ANNOTATION}</pre> annotation is missing on the entity.
+      </WarningPanel>
+    );
+  }
+
+  return (
     <Routes>
       <Route
         path="/"
         element={
-          <SentryPluginWidget
-            sentryProjectId={
-              entity.metadata.annotations?.[SENTRY_ANNOTATION] || ''
-            }
-            statsFor="24h"
-          />
+          <SentryPluginWidget sentryProjectId={projectId} statsFor="24h" />
         }
       />
       )
     </Routes>
   );
+};