core-plugin-api: Remove deprecated get method from StorageApi

Signed-off-by: Johan Haals <johan.haals@gmail.com>

plugins/catalog/src/apis/StarredEntitiesApi/DefaultStarredEntitiesApi.ts

@@ -36,12 +36,12 @@ export class DefaultStarredEntitiesApi implements StarredEntitiesApi {
     this.settingsStore = opts.storageApi.forBucket('starredEntities');
 
     this.starredEntities = new Set(
-      this.settingsStore.get<string[]>('entityRefs') ?? [],
+      this.settingsStore.snapshot<string[]>('entityRefs').value ?? [],
     );
 
     this.settingsStore.observe$<string[]>('entityRefs').subscribe({
       next: next => {
-        this.starredEntities = new Set(next.newValue ?? []);
+        this.starredEntities = new Set(next.value ?? []);
         this.notifyChanges();
       },
     });

plugins/catalog/src/apis/StarredEntitiesApi/migration.test.ts

@@ -41,19 +41,19 @@ describe('performMigrationToTheNewBucket', () => {
       'entity:Component:default:a',
       'entity:template:custom:b',
     ]);
-    expect(oldBucket.get('starredEntities')).not.toBeUndefined();
+    expect(oldBucket.snapshot('starredEntities').value).not.toBeUndefined();
 
     await performMigrationToTheNewBucket({ storageApi: mockStorage });
 
     // read NEW bucket
-    expect(await newBucket.get('entityRefs')).toEqual([
+    expect(await newBucket.snapshot('entityRefs').value).toEqual([
       'component:default/c',
       'component:default/a',
       'template:custom/b',
     ]);
 
     // OLD bucket should be removed
-    expect(oldBucket.get('starredEntities')).toBeUndefined();
+    expect(oldBucket.snapshot('starredEntities').value).toBeUndefined();
   });
 
   it('should ignore invalid entries', async () => {
@@ -67,15 +67,17 @@ describe('performMigrationToTheNewBucket', () => {
       'entity:Component:a',
       'invalid',
     ]);
-    expect(oldBucket.get('starredEntities')).not.toBeUndefined();
+    expect(oldBucket.snapshot('starredEntities')).not.toBeUndefined();
 
     await performMigrationToTheNewBucket({ storageApi: mockStorage });
 
     // read NEW bucket
-    expect(await newBucket.get('entityRefs')).toEqual(['component:default/a']);
+    expect(await newBucket.snapshot('entityRefs').value).toEqual([
+      'component:default/a',
+    ]);
 
     // OLD bucket should be removed
-    expect(oldBucket.get('starredEntities')).toBeUndefined();
+    expect(oldBucket.snapshot('starredEntities').value).toBeUndefined();
   });
 
   it('should skip migration without old starred entities', async () => {
@@ -88,7 +90,7 @@ describe('performMigrationToTheNewBucket', () => {
     await performMigrationToTheNewBucket({ storageApi: mockStorage });
 
     // read NEW bucket
-    expect(newBucket.get('entityRefs')).toEqual(expectedEntries);
+    expect(newBucket.snapshot('entityRefs').value).toEqual(expectedEntries);
   });
 
   it('should skip migration with non-array old starred entities', async () => {
@@ -105,9 +107,9 @@ describe('performMigrationToTheNewBucket', () => {
     await performMigrationToTheNewBucket({ storageApi: mockStorage });
 
     // read NEW bucket
-    expect(newBucket.get('entityRefs')).toEqual(expectedEntries);
+    expect(newBucket.snapshot('entityRefs').value).toEqual(expectedEntries);
 
     // OLD bucket should be unchanged
-    expect(oldBucket.get('starredEntities')).toBe('invalid');
+    expect(oldBucket.snapshot('starredEntities').value).toBe('invalid');
   });
 });

plugins/catalog/src/apis/StarredEntitiesApi/migration.ts

@@ -35,13 +35,15 @@ export async function performMigrationToTheNewBucket({
   const source = storageApi.forBucket('settings');
   const target = storageApi.forBucket('starredEntities');
 
-  const oldStarredEntities = source.get('starredEntities');
+  const oldStarredEntities = source.snapshot('starredEntities').value;
 
   if (!isArray(oldStarredEntities)) {
     // nothing to do
     return;
   }
-  const targetEntities = new Set(target.get<string[]>('entityRefs') ?? []);
+  const targetEntities = new Set(
+    target.snapshot<string[]>('entityRefs').value ?? [],
+  );
 
   oldStarredEntities
     .filter(isString)