From 290905428348abaa08304782869a126dd2e04a44 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Sun, 2 Aug 2020 23:20:39 +0200 Subject: [PATCH 1/4] create-app: add lint command --- packages/create-app/.eslintrc.js | 1 + packages/create-app/package.json | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/create-app/.eslintrc.js b/packages/create-app/.eslintrc.js index 503c048748..69bec6cd2a 100644 --- a/packages/create-app/.eslintrc.js +++ b/packages/create-app/.eslintrc.js @@ -1,5 +1,6 @@ module.exports = { extends: [require.resolve('@backstage/cli/config/eslint.backend')], + ignorePatterns: ['templates/**'], rules: { 'no-console': 0, }, diff --git a/packages/create-app/package.json b/packages/create-app/package.json index 282a1f692f..8b63cbba04 100644 --- a/packages/create-app/package.json +++ b/packages/create-app/package.json @@ -21,7 +21,8 @@ "backstage-create-app": "bin/backstage-create-app" }, "scripts": { - "build": "backstage-cli build --outputs cjs" + "build": "backstage-cli build --outputs cjs", + "lint": "backstage-cli lint" }, "dependencies": { "commander": "^4.1.1", From fb1ee745516d75081fb2f5aeb5d35f941719670b Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Sun, 2 Aug 2020 23:57:23 +0200 Subject: [PATCH 2/4] create-app: fix deps --- packages/create-app/package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/create-app/package.json b/packages/create-app/package.json index 8b63cbba04..df1951106c 100644 --- a/packages/create-app/package.json +++ b/packages/create-app/package.json @@ -28,10 +28,10 @@ "commander": "^4.1.1", "chalk": "^4.0.0", "fs-extra": "^9.0.0", - "react-dev-utils": "^10.2.1", + "handlebars": "^4.7.3", "inquirer": "^7.0.4", - "recursive-readdir": "^2.2.2", - "ora": "^4.0.3" + "ora": "^4.0.3", + "recursive-readdir": "^2.2.2" }, "devDependencies": { "@types/fs-extra": "^9.0.1", From d1c7d8672a8aac04aa426d378ef329b165b8fbfc Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Sun, 2 Aug 2020 23:57:33 +0200 Subject: [PATCH 3/4] create-app: sync version --- packages/create-app/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-app/package.json b/packages/create-app/package.json index df1951106c..79b14fc379 100644 --- a/packages/create-app/package.json +++ b/packages/create-app/package.json @@ -1,7 +1,7 @@ { "name": "@backstage/create-app", "description": "Create app package for Backstage", - "version": "0.1.1-alpha.12", + "version": "0.1.1-alpha.16", "private": false, "publishConfig": { "access": "public" From 2c4ee49be89fd20a095835b228fa17797e04e23e Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Mon, 3 Aug 2020 00:17:21 +0200 Subject: [PATCH 4/4] workflows: run cli checks on changes to create-app --- .github/workflows/cli-win.yml | 1 + .github/workflows/cli.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/cli-win.yml b/.github/workflows/cli-win.yml index 1355ed251e..4e7a186282 100644 --- a/.github/workflows/cli-win.yml +++ b/.github/workflows/cli-win.yml @@ -7,6 +7,7 @@ on: paths: - '.github/workflows/cli-win.yml' - 'packages/cli/**' + - 'packages/create-app/**' jobs: build: diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml index 32fb15d329..6e4fdad214 100644 --- a/.github/workflows/cli.yml +++ b/.github/workflows/cli.yml @@ -5,6 +5,7 @@ on: paths: - '.github/workflows/cli.yml' - 'packages/cli/**' + - 'packages/create-app/**' - 'packages/core/**' - 'packages/core-api/**' - 'yarn.lock'