From bafc399585888adb8cd1b43b48052fece7e8ed91 Mon Sep 17 00:00:00 2001
From: Zack Griesinger <zack.griesinger@c2fo.com>
Date: Mon, 27 Dec 2021 15:54:10 -0600
Subject: [PATCH] Add better logging and fix command index

Signed-off-by: Zack Griesinger <zack.griesinger@c2fo.com>
---
 packages/cli/src/commands/index.ts              | 2 +-
 packages/cli/src/commands/versions/bump.test.ts | 3 +++
 packages/cli/src/commands/versions/bump.ts      | 7 ++++++-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/packages/cli/src/commands/index.ts b/packages/cli/src/commands/index.ts
index d85cab0a8c..81d5fb7f1f 100644
--- a/packages/cli/src/commands/index.ts
+++ b/packages/cli/src/commands/index.ts
@@ -214,7 +214,7 @@ export function registerCommands(program: CommanderStatic) {
 
   program
     .command('versions:bump')
-    .option('--prefix', 'Override glob for matching packages to upgrade')
+    .option('--prefix <glob>', 'Override glob for matching packages to upgrade')
     .description('Bump Backstage packages to the latest versions')
     .action(lazy(() => import('./versions/bump').then(m => m.default)));
 
diff --git a/packages/cli/src/commands/versions/bump.test.ts b/packages/cli/src/commands/versions/bump.test.ts
index fe529b0769..19e0d28553 100644
--- a/packages/cli/src/commands/versions/bump.test.ts
+++ b/packages/cli/src/commands/versions/bump.test.ts
@@ -129,6 +129,7 @@ describe('bump', () => {
       await bump({ prefix: null } as Command);
     });
     expect(logs.filter(Boolean)).toEqual([
+      'Using default prefix glob @backstage/*',
       'Checking for updates of @backstage/theme',
       'Checking for updates of @backstage/core',
       'Checking for updates of @backstage/core-api',
@@ -254,6 +255,7 @@ describe('bump', () => {
       await bump({ prefix: '@{backstage,backstage-extra}/*' } as any);
     });
     expect(logs.filter(Boolean)).toEqual([
+      'Using custom prefix glob @{backstage,backstage-extra}/*',
       'Checking for updates of @backstage/theme',
       'Checking for updates of @backstage-extra/custom-two',
       'Checking for updates of @backstage-extra/custom',
@@ -350,6 +352,7 @@ describe('bump', () => {
       await bump({ prefix: null } as any);
     });
     expect(logs.filter(Boolean)).toEqual([
+      'Using default prefix glob @backstage/*',
       'Checking for updates of @backstage/theme',
       'Checking for updates of @backstage/core',
       'Package info not found, ignoring package @backstage/theme',
diff --git a/packages/cli/src/commands/versions/bump.ts b/packages/cli/src/commands/versions/bump.ts
index ce737cd2e3..b9ee85fe0e 100644
--- a/packages/cli/src/commands/versions/bump.ts
+++ b/packages/cli/src/commands/versions/bump.ts
@@ -38,6 +38,8 @@ const DEP_TYPES = [
   'optionalDependencies',
 ];
 
+const DEFAULT_PREFIX_GLOB = '@backstage/*';
+
 type PkgVersionInfo = {
   range: string;
   target: string;
@@ -51,7 +53,10 @@ export default async (cmd: Command) => {
   let prefix = cmd.prefix;
 
   if (!prefix) {
-    prefix = '@backstage/*';
+    console.log(`Using default prefix glob ${DEFAULT_PREFIX_GLOB}`);
+    prefix = DEFAULT_PREFIX_GLOB;
+  } else {
+    console.log(`Using custom prefix glob ${prefix}`);
   }
 
   const findTargetVersion = createVersionFinder();