From b8d6b22acd57e307846b3486fa110655896ae040 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Thu, 10 Aug 2023 11:25:53 +0200
Subject: [PATCH] catalog-backend: inline synthetic load test module

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .changeset/fast-peas-live.md                  |  5 +++
 .../lib/catalogModuleSyntheticLoadEntities.ts | 40 +++++--------------
 .../performance/stitchingPerformance.test.ts  | 28 ++++++++++---
 3 files changed, 38 insertions(+), 35 deletions(-)
 create mode 100644 .changeset/fast-peas-live.md

diff --git a/.changeset/fast-peas-live.md b/.changeset/fast-peas-live.md
new file mode 100644
index 0000000000..5cf91079b9
--- /dev/null
+++ b/.changeset/fast-peas-live.md
@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-catalog-backend': patch
+---
+
+Internal refactor for load test
diff --git a/plugins/catalog-backend/src/tests/performance/lib/catalogModuleSyntheticLoadEntities.ts b/plugins/catalog-backend/src/tests/performance/lib/catalogModuleSyntheticLoadEntities.ts
index 4d38b28bcf..7925b0b552 100644
--- a/plugins/catalog-backend/src/tests/performance/lib/catalogModuleSyntheticLoadEntities.ts
+++ b/plugins/catalog-backend/src/tests/performance/lib/catalogModuleSyntheticLoadEntities.ts
@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { createBackendModule } from '@backstage/backend-plugin-api';
 import { Entity } from '@backstage/catalog-model';
 import { LocationSpec } from '@backstage/plugin-catalog-common';
 import {
@@ -26,7 +25,6 @@ import {
   EntityProviderConnection,
   processingResult,
 } from '@backstage/plugin-catalog-node';
-import { catalogProcessingExtensionPoint } from '@backstage/plugin-catalog-node/alpha';
 
 /**
  * Options for a fixed initial load of entities.
@@ -143,12 +141,15 @@ export const common = {
 
 /**
  * The entity provider that drives the initial base entity injection
+ * @internal
  */
-class SyntheticLoadEntitiesProvider implements EntityProvider {
+export class SyntheticLoadEntitiesProvider implements EntityProvider {
   constructor(
     private readonly load: SyntheticLoadOptions,
     private readonly events: SyntheticLoadEvents,
-  ) {}
+  ) {
+    validateSyntheticLoadOptions(load);
+  }
 
   getProviderName(): string {
     return 'SyntheticLoadEntitiesProvider';
@@ -180,9 +181,12 @@ class SyntheticLoadEntitiesProvider implements EntityProvider {
 
 /**
  * Supporting processor for emitting children and relations
+ * @internal
  */
-class SyntheticLoadEntitiesProcessor implements CatalogProcessor {
-  constructor(private readonly load: SyntheticLoadOptions) {}
+export class SyntheticLoadEntitiesProcessor implements CatalogProcessor {
+  constructor(private readonly load: SyntheticLoadOptions) {
+    validateSyntheticLoadOptions(load);
+  }
 
   getProcessorName(): string {
     return 'SyntheticLoadEntitiesProcessor';
@@ -231,27 +235,3 @@ class SyntheticLoadEntitiesProcessor implements CatalogProcessor {
     return entity;
   }
 }
-
-export const catalogModuleSyntheticLoadEntities = createBackendModule(
-  (options: { load: SyntheticLoadOptions; events?: SyntheticLoadEvents }) => ({
-    moduleId: 'syntheticLoadEntities',
-    pluginId: 'catalog',
-    register(reg) {
-      reg.registerInit({
-        deps: {
-          catalog: catalogProcessingExtensionPoint,
-        },
-        async init({ catalog }) {
-          const { load, events = {} } = options;
-
-          validateSyntheticLoadOptions(load);
-          const provider = new SyntheticLoadEntitiesProvider(load, events);
-          const processor = new SyntheticLoadEntitiesProcessor(load);
-
-          catalog.addEntityProvider(provider);
-          catalog.addProcessor(processor);
-        },
-      });
-    },
-  }),
-);
diff --git a/plugins/catalog-backend/src/tests/performance/stitchingPerformance.test.ts b/plugins/catalog-backend/src/tests/performance/stitchingPerformance.test.ts
index 2f32fcd907..9cb20d557d 100644
--- a/plugins/catalog-backend/src/tests/performance/stitchingPerformance.test.ts
+++ b/plugins/catalog-backend/src/tests/performance/stitchingPerformance.test.ts
@@ -16,16 +16,19 @@
 
 import {
   coreServices,
+  createBackendModule,
   createServiceFactory,
 } from '@backstage/backend-plugin-api';
 import { TestDatabases, startTestBackend } from '@backstage/backend-test-utils';
 import { catalogPlugin } from '@backstage/plugin-catalog-backend/alpha';
+import { catalogProcessingExtensionPoint } from '@backstage/plugin-catalog-node/alpha';
 import { Knex } from 'knex';
 import { applyDatabaseMigrations } from '../../database/migrations';
 import {
   SyntheticLoadEvents,
   SyntheticLoadOptions,
-  catalogModuleSyntheticLoadEntities,
+  SyntheticLoadEntitiesProvider,
+  SyntheticLoadEntitiesProcessor,
 } from './lib/catalogModuleSyntheticLoadEntities';
 import { describePerformanceTest, performanceTraceEnabled } from './lib/env';
 
@@ -180,10 +183,25 @@ describePerformanceTest('stitchingPerformance', () => {
         services: [staticDatabase(knex)],
         features: [
           catalogPlugin(),
-          catalogModuleSyntheticLoadEntities({
-            load,
-            events: tracker.events(),
-          }),
+          createBackendModule({
+            moduleId: 'syntheticLoadEntities',
+            pluginId: 'catalog',
+            register(reg) {
+              reg.registerInit({
+                deps: {
+                  catalog: catalogProcessingExtensionPoint,
+                },
+                async init({ catalog }) {
+                  catalog.addEntityProvider(
+                    new SyntheticLoadEntitiesProvider(load, tracker.events()),
+                  );
+                  catalog.addProcessor(
+                    new SyntheticLoadEntitiesProcessor(load),
+                  );
+                },
+              });
+            },
+          })(),
         ],
       });