paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 46 Packages Projects Releases Wiki Activity

PR Feedback

Browse Source 
Signed-off-by: Alex Crome <afscrome@users.noreply.github.com>
This commit is contained in:
Alex Crome
2023-02-14 14:50:37 +00:00
parent aa721158d1
commit b84349e2f6
4 changed files with 9 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/auth-backend/src/providers/azure-easyauth/provider.test.ts
+1 -1
View File
@@ -256,7 +256,7 @@ describe('easyAuth factory', () => {
});
expect(() => factory({} as any)).toThrow(
'Authentication provider is not Azure Active Directory',
'Authentication provider is not Azure Active Directory',
);
});
plugins/auth-backend/src/providers/azure-easyauth/provider.ts
+4 -14
View File
@@ -178,25 +178,15 @@ function validateAppServiceConfiguration(env: NodeJS.ProcessEnv) {
if (env.WEBSITE_SKU === undefined) {
throw new Error('Backstage is not running on Azure App Services');
}
if (!isEqualCaseInsensitive(env.WEBSITE_AUTH_ENABLED, 'True')) {
if (env.WEBSITE_AUTH_ENABLED?.toLowerCase() !== 'true') {
throw new Error('Azure App Services does not have authentication enabled');
}
if (
!isEqualCaseInsensitive(
env.WEBSITE_AUTH_DEFAULT_PROVIDER,
'AzureActiveDirectory',
)
env.WEBSITE_AUTH_DEFAULT_PROVIDER?.toLowerCase() !== 'azureactivedirectory'
) {
throw new Error('Authentication provider is not Azure Active Directory');
throw new Error('Authentication provider is not Azure Active Directory');
}
if (!isEqualCaseInsensitive(process.env.WEBSITE_AUTH_TOKEN_STORE, 'True')) {
if (process.env.WEBSITE_AUTH_TOKEN_STORE?.toLowerCase() !== 'true') {
throw new Error('Token Store is not enabled');
}
}
function isEqualCaseInsensitive(left: string | undefined, right: string) {
return (
left !== undefined &&
right.localeCompare(left, undefined, { sensitivity: 'base' }) === 0
);
}