From b77a9852059e80b019698e9636b331332048e2f8 Mon Sep 17 00:00:00 2001
From: Johan Haals <johan.haals@gmail.com>
Date: Thu, 28 Jan 2021 09:33:55 +0100
Subject: [PATCH] Update templater tests

---
 .../stages/templater/templaters.test.ts       | 92 +------------------
 1 file changed, 2 insertions(+), 90 deletions(-)

diff --git a/plugins/scaffolder-backend/src/scaffolder/stages/templater/templaters.test.ts b/plugins/scaffolder-backend/src/scaffolder/stages/templater/templaters.test.ts
index 9ef20b7740..209210c075 100644
--- a/plugins/scaffolder-backend/src/scaffolder/stages/templater/templaters.test.ts
+++ b/plugins/scaffolder-backend/src/scaffolder/stages/templater/templaters.test.ts
@@ -14,52 +14,13 @@
  * limitations under the License.
  */
 import { Templaters } from '.';
-import { TemplateEntityV1alpha1 } from '@backstage/catalog-model';
 import { CookieCutter } from './cookiecutter';
 
 describe('Templaters', () => {
-  const mockTemplate: TemplateEntityV1alpha1 = {
-    apiVersion: 'backstage.io/v1alpha1',
-    kind: 'Template',
-    metadata: {
-      annotations: {
-        'backstage.io/managed-by-location':
-          'file:/Users/bingo/backstage/plugins/scaffolder-backend/sample-templates/react-ssr-template/template.yaml',
-      },
-      name: 'react-ssr-template',
-      title: 'React SSR Template',
-      description:
-        'Next.js application skeleton for creating isomorphic web applications.',
-      uid: '7357f4c5-aa58-4a1e-9670-18931eef771f',
-      etag: 'YWUxZWQyY2EtZDkxMC00MDM0LWI0ODAtMDgwMWY0YzdlMWIw',
-      generation: 1,
-    },
-    spec: {
-      templater: 'cookiecutter',
-      path: '.',
-      type: 'website',
-      schema: {
-        $schema: 'http://json-schema.org/draft-07/schema#',
-        required: ['storePath', 'owner'],
-        properties: {
-          owner: {
-            type: 'string',
-            title: 'Owner',
-            description: 'Who is going to own this component',
-          },
-          storePath: {
-            type: 'string',
-            title: 'Store path',
-            description: 'GitHub store path in org/repo format',
-          },
-        },
-      },
-    },
-  };
   it('should throw an error when the templater is not registered', () => {
     const templaters = new Templaters();
 
-    expect(() => templaters.get(mockTemplate)).toThrow(
+    expect(() => templaters.get('cookiecutter')).toThrow(
       expect.objectContaining({
         message: 'No templater registered for template: "cookiecutter"',
       }),
@@ -71,55 +32,6 @@ describe('Templaters', () => {
 
     templaters.register('cookiecutter', templater);
 
-    expect(templaters.get(mockTemplate)).toBe(templater);
-  });
-
-  it('should throw an error if the templater does not exist in the entity', () => {
-    const brokenTemplate: TemplateEntityV1alpha1 = {
-      apiVersion: 'backstage.io/v1alpha1',
-      kind: 'Template',
-      metadata: {
-        annotations: {},
-        name: 'react-ssr-template',
-        title: 'React SSR Template',
-        description:
-          'Next.js application skeleton for creating isomorphic web applications.',
-        uid: '7357f4c5-aa58-4a1e-9670-18931eef771f',
-        etag: 'YWUxZWQyY2EtZDkxMC00MDM0LWI0ODAtMDgwMWY0YzdlMWIw',
-        generation: 1,
-      },
-      spec: {
-        type: 'website',
-        path: '.',
-        templater: '',
-        schema: {
-          $schema: 'http://json-schema.org/draft-07/schema#',
-          required: ['storePath', 'owner'],
-          properties: {
-            owner: {
-              type: 'string',
-              title: 'Owner',
-              description: 'Who is going to own this component',
-            },
-            storePath: {
-              type: 'string',
-              title: 'Store path',
-              description: 'GitHub store path in org/repo format',
-            },
-          },
-        },
-      },
-    };
-
-    const templaters = new Templaters();
-
-    expect(() => templaters.get(brokenTemplate)).toThrow(
-      expect.objectContaining({
-        name: 'InputError',
-        message: expect.stringContaining(
-          'Template does not have a required templating key',
-        ),
-      }),
-    );
+    expect(templaters.get('cookiecutter')).toBe(templater);
   });
 });