From b73b0fe9792cd4b09f89ead00517cf6df92ab0fc Mon Sep 17 00:00:00 2001 From: Himanshu Mishra Date: Wed, 10 Feb 2021 12:21:14 +0100 Subject: [PATCH] techdocs: don't swallow errors other than NotModifiedError --- plugins/techdocs-backend/src/DocsBuilder/builder.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/plugins/techdocs-backend/src/DocsBuilder/builder.ts b/plugins/techdocs-backend/src/DocsBuilder/builder.ts index 2ce7464a55..8c54a2b1e4 100644 --- a/plugins/techdocs-backend/src/DocsBuilder/builder.ts +++ b/plugins/techdocs-backend/src/DocsBuilder/builder.ts @@ -13,6 +13,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ +import { NotModifiedError } from '@backstage/backend-common'; import { Entity } from '@backstage/catalog-model'; import { GeneratorBase, @@ -98,9 +99,12 @@ export class DocsBuilder { preparedDir = preparerResponse.preparedDir; etag = preparerResponse.etag; - } catch (NotModifiedError) { - // No need to prepare anymore since cache is valid. - return; + } catch (err) { + if (err instanceof NotModifiedError) { + // No need to prepare anymore since cache is valid. + return; + } + throw new Error(err.message); } this.logger.info(