From b609e94a37252c6be8ba25d41d6756325173bc26 Mon Sep 17 00:00:00 2001
From: Juan Lulkin <jmaiz@spotify.com>
Date: Sat, 20 Feb 2021 19:38:05 +0100
Subject: [PATCH] Makes verify sidebar script assume build is present

---
 .github/workflows/microsite-build-check.yml | 10 ++++----
 microsite/scripts/verify-sidebars.js        | 27 ++++++---------------
 2 files changed, 13 insertions(+), 24 deletions(-)

diff --git a/.github/workflows/microsite-build-check.yml b/.github/workflows/microsite-build-check.yml
index a67efe9119..a6fed59e08 100644
--- a/.github/workflows/microsite-build-check.yml
+++ b/.github/workflows/microsite-build-check.yml
@@ -34,11 +34,7 @@ jobs:
         # smaller, which make Windows builds a lot faster for the rest of the project.
       - name: yarn install
         run: yarn install --frozen-lockfile
-        working-directory: microsite
-
-      - name: verify sidebars
-        run: yarn verify:sidebars
-        working-directory: microsite        
+        working-directory: microsite    
 
       - name: prettier
         run: yarn prettier:check
@@ -47,3 +43,7 @@ jobs:
       - name: build microsite
         run: yarn build
         working-directory: microsite
+
+      - name: verify sidebars
+        run: yarn verify:sidebars
+        working-directory: microsite    
\ No newline at end of file
diff --git a/microsite/scripts/verify-sidebars.js b/microsite/scripts/verify-sidebars.js
index 8a72d494ce..7c378c90cd 100755
--- a/microsite/scripts/verify-sidebars.js
+++ b/microsite/scripts/verify-sidebars.js
@@ -19,24 +19,13 @@
  * docusaurus adds proper validation of the sidebar items.
  */
 
-require('@babel/polyfill');
-require('@babel/register')({
-  babelrc: false,
-  only: [`${__dirname}/..`, `${process.cwd()}/core`],
-  plugins: [
-    require('docusaurus/lib/server/translate-plugin.js'),
-    require('@babel/plugin-proposal-class-properties').default,
-    require('@babel/plugin-proposal-object-rest-spread').default,
-  ],
-  presets: [
-    require('@babel/preset-react').default,
-    require('@babel/preset-env').default,
-  ],
-});
-
-const readMetadata = require('docusaurus/lib/server/readMetadata.js');
-readMetadata.generateMetadataDocs();
-const metadata = require('docusaurus/lib/core/metadata.js');
+let metadata;
+try {
+  metadata = require('docusaurus/lib/core/metadata.js');
+} catch (error) {
+  console.log('❌ Run `yarn build` before running `yarn verify:sidebars`');
+  process.exit(1);
+}
 
 const errors = [];
 const ids = Object.keys(metadata);
@@ -53,7 +42,7 @@ for (let id of ids) {
 }
 
 if (errors.length) {
-  for (let error of errors) {
+  for (const error of errors) {
     console.log(`❌ ${error}`);
   }
   process.exit(1);