From b5b9b8d98ae74e5db0867f8dfe3902e74d675591 Mon Sep 17 00:00:00 2001
From: Camila Belo <camilaibs@gmail.com>
Date: Tue, 30 Jan 2024 11:30:33 +0100
Subject: [PATCH] fix: analytics catagory locale

Signed-off-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .../implementations/AnalyticsApi/GoogleAnalytics.test.ts   | 2 +-
 .../apis/implementations/AnalyticsApi/GoogleAnalytics.ts   | 7 +++++--
 .../implementations/AnalyticsApi/GoogleAnalytics4.test.ts  | 2 +-
 .../apis/implementations/AnalyticsApi/GoogleAnalytics4.ts  | 7 +++++--
 .../apis/implementations/AnalyticsApi/NewRelicBrowser.ts   | 7 +++++--
 5 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/plugins/analytics-module-ga/src/apis/implementations/AnalyticsApi/GoogleAnalytics.test.ts b/plugins/analytics-module-ga/src/apis/implementations/AnalyticsApi/GoogleAnalytics.test.ts
index 056efdb3e6..48e43c2a45 100644
--- a/plugins/analytics-module-ga/src/apis/implementations/AnalyticsApi/GoogleAnalytics.test.ts
+++ b/plugins/analytics-module-ga/src/apis/implementations/AnalyticsApi/GoogleAnalytics.test.ts
@@ -585,7 +585,7 @@ describe('GoogleAnalytics', () => {
       expect(data).toMatchObject({
         hitType: 'event',
         // expect to use the new default category
-        eventCategory: 'app',
+        eventCategory: 'App',
         eventAction: 'click',
         eventLabel: 'on something',
         eventValue: 42,
diff --git a/plugins/analytics-module-ga/src/apis/implementations/AnalyticsApi/GoogleAnalytics.ts b/plugins/analytics-module-ga/src/apis/implementations/AnalyticsApi/GoogleAnalytics.ts
index 045bc94f3a..d241cd9860 100644
--- a/plugins/analytics-module-ga/src/apis/implementations/AnalyticsApi/GoogleAnalytics.ts
+++ b/plugins/analytics-module-ga/src/apis/implementations/AnalyticsApi/GoogleAnalytics.ts
@@ -167,10 +167,13 @@ export class GoogleAnalytics implements AnalyticsApi, NewAnalyticsApi {
     const customMetadata = this.getCustomDimensionMetrics(context, attributes);
 
     const extensionId = context.extensionId || context.extension;
-    const category = extensionId ? String(extensionId) : 'app';
+    const category = extensionId ? String(extensionId) : 'App';
 
     // The legacy default extension was 'App' and the new one is 'app'
-    if (action === 'navigate' && category.toLocaleLowerCase() === 'app') {
+    if (
+      action === 'navigate' &&
+      category.toLocaleLowerCase('en-US').startsWith('app')
+    ) {
       this.capture.pageview(subject, customMetadata);
       return;
     }
diff --git a/plugins/analytics-module-ga4/src/apis/implementations/AnalyticsApi/GoogleAnalytics4.test.ts b/plugins/analytics-module-ga4/src/apis/implementations/AnalyticsApi/GoogleAnalytics4.test.ts
index 93a6e6fe6a..025462903b 100644
--- a/plugins/analytics-module-ga4/src/apis/implementations/AnalyticsApi/GoogleAnalytics4.test.ts
+++ b/plugins/analytics-module-ga4/src/apis/implementations/AnalyticsApi/GoogleAnalytics4.test.ts
@@ -526,7 +526,7 @@ describe('GoogleAnalytics4', () => {
       expect(fnEvent).toHaveBeenCalledWith('page_view', {
         action: 'page_view',
         label: '/',
-        category: 'app',
+        category: 'App',
       });
     });
 
diff --git a/plugins/analytics-module-ga4/src/apis/implementations/AnalyticsApi/GoogleAnalytics4.ts b/plugins/analytics-module-ga4/src/apis/implementations/AnalyticsApi/GoogleAnalytics4.ts
index 1f4cbfeee5..43ff47b84e 100644
--- a/plugins/analytics-module-ga4/src/apis/implementations/AnalyticsApi/GoogleAnalytics4.ts
+++ b/plugins/analytics-module-ga4/src/apis/implementations/AnalyticsApi/GoogleAnalytics4.ts
@@ -171,10 +171,13 @@ export class GoogleAnalytics4 implements AnalyticsApi, NewAnalyticsApi {
     }
 
     const extensionId = context.extensionId || context.extension;
-    const category = extensionId ? String(extensionId) : 'app';
+    const category = extensionId ? String(extensionId) : 'App';
 
     // The legacy default extension was 'App' and the new one is 'app'
-    if (action === 'navigate' && category.toLocaleLowerCase() === 'app') {
+    if (
+      action === 'navigate' &&
+      category.toLocaleLowerCase('en-US').startsWith('app')
+    ) {
       this.capture.event(
         {
           category,
diff --git a/plugins/analytics-module-newrelic-browser/src/apis/implementations/AnalyticsApi/NewRelicBrowser.ts b/plugins/analytics-module-newrelic-browser/src/apis/implementations/AnalyticsApi/NewRelicBrowser.ts
index ba04aea322..d65d02db64 100644
--- a/plugins/analytics-module-newrelic-browser/src/apis/implementations/AnalyticsApi/NewRelicBrowser.ts
+++ b/plugins/analytics-module-newrelic-browser/src/apis/implementations/AnalyticsApi/NewRelicBrowser.ts
@@ -129,10 +129,13 @@ export class NewRelicBrowser implements AnalyticsApi, NewAnalyicsApi {
     const { context, action, subject, value, attributes } = event;
 
     const extensionId = context.extensionId || context.extension;
-    const category = extensionId ? String(extensionId) : 'app';
+    const category = extensionId ? String(extensionId) : 'App';
 
     // The legacy default extension was 'App' and the new one is 'app'
-    if (action === 'navigate' && category.toLocaleLowerCase() === 'app') {
+    if (
+      action === 'navigate' &&
+      category.toLocaleLowerCase('en-US').startsWith('app')
+    ) {
       const interaction = this.agent.interaction();
       interaction.setName(subject);
       if (value) {