From b57db403ac95eaa7a67f0a346af712368e6450d7 Mon Sep 17 00:00:00 2001 From: "Chongyang Adrian, Ke" Date: Tue, 18 May 2021 10:32:38 +0800 Subject: [PATCH] use UrlSearchParams Signed-off-by: Chongyang Adrian, Ke --- packages/backend-common/src/reading/GitlabUrlReader.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/backend-common/src/reading/GitlabUrlReader.ts b/packages/backend-common/src/reading/GitlabUrlReader.ts index a9365e1b09..9dcbd5783c 100644 --- a/packages/backend-common/src/reading/GitlabUrlReader.ts +++ b/packages/backend-common/src/reading/GitlabUrlReader.ts @@ -108,14 +108,16 @@ export class GitlabUrlReader implements UrlReader { // Fetch the latest commit that modifies the the filepath in the provided or default branch // to compare against the provided sha. - const branchQuery = `ref_name=${branch}`; - const pathQuery = !!filepath ? `&path=${filepath}` : ''; - + const commitsReqParams = new URLSearchParams(); + commitsReqParams.set('ref_name', branch); + if (!!filepath) { + commitsReqParams.set('path', filepath); + } const commitsGitlabResponse = await fetch( new URL( `${this.integration.config.apiBaseUrl}/projects/${encodeURIComponent( full_name, - )}/repository/commits?${branchQuery}${pathQuery}`, + )}/repository/commits?${commitsReqParams.toString()}`, ).toString(), getGitLabRequestOptions(this.integration.config), );