From 71fb4e1281b57754ed8cb9765bba2018678d98a4 Mon Sep 17 00:00:00 2001 From: Johan Haals Date: Wed, 13 Jan 2021 16:58:11 +0100 Subject: [PATCH 1/3] cli: Remove api url from github app configuration --- .../src/commands/create-github-app/GithubCreateAppServer.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/cli/src/commands/create-github-app/GithubCreateAppServer.ts b/packages/cli/src/commands/create-github-app/GithubCreateAppServer.ts index 406e563ebc..45671c2ead 100644 --- a/packages/cli/src/commands/create-github-app/GithubCreateAppServer.ts +++ b/packages/cli/src/commands/create-github-app/GithubCreateAppServer.ts @@ -47,7 +47,6 @@ const FORM_PAGE = ` type GithubAppConfig = { appId: number; - apiUrl: string; slug?: string; name?: string; webhookUrl?: string; @@ -88,14 +87,11 @@ export class GithubCreateAppServer { `POST /app-manifests/${encodeURIComponent( req.query.code as string, )}/conversions`, - ).then(({ data, url }) => { - // url = https://api.github.com/app-manifests//conversions - const apiUrl = url.replace(/(?:\/[^\/]+){3}$/, ''); + ).then(({ data }) => { resolve({ name: data.name, slug: data.slug, appId: data.id, - apiUrl, webhookUrl: this.webhookUrl, clientId: data.client_id, clientSecret: data.client_secret, From 8277fe6f77094d3254c268ec8e5c64c28221242c Mon Sep 17 00:00:00 2001 From: Johan Haals Date: Wed, 13 Jan 2021 17:04:10 +0100 Subject: [PATCH 2/3] Add changeset --- .changeset/real-vans-provide.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/real-vans-provide.md diff --git a/.changeset/real-vans-provide.md b/.changeset/real-vans-provide.md new file mode 100644 index 0000000000..9d83804bd6 --- /dev/null +++ b/.changeset/real-vans-provide.md @@ -0,0 +1,5 @@ +--- +'@backstage/cli': patch +--- + +Remove `apiUrl` from the output of the create-github-app because apiUrl already exist in the GitHub integration config. From c09215095b1fdc29f4a9919b93f33286c26ef574 Mon Sep 17 00:00:00 2001 From: blam Date: Thu, 14 Jan 2021 13:18:56 +0100 Subject: [PATCH 3/3] chore: remove the changeset as we will do it in this release --- .changeset/real-vans-provide.md | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 .changeset/real-vans-provide.md diff --git a/.changeset/real-vans-provide.md b/.changeset/real-vans-provide.md deleted file mode 100644 index 9d83804bd6..0000000000 --- a/.changeset/real-vans-provide.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@backstage/cli': patch ---- - -Remove `apiUrl` from the output of the create-github-app because apiUrl already exist in the GitHub integration config.