From b519606f3ae0641c90a5cb226ab96adc18731af5 Mon Sep 17 00:00:00 2001 From: ahrberg Date: Wed, 13 Jan 2021 08:24:45 +0100 Subject: [PATCH] cli: review feedback --- packages/cli/src/commands/versions/bump.ts | 2 +- packages/cli/src/lib/versioning/packages.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/cli/src/commands/versions/bump.ts b/packages/cli/src/commands/versions/bump.ts index af670d4a8b..753c5d5b57 100644 --- a/packages/cli/src/commands/versions/bump.ts +++ b/packages/cli/src/commands/versions/bump.ts @@ -98,7 +98,7 @@ export default async () => { try { target = await findTargetVersion(name); } catch (error) { - if (error instanceof NotFoundError) { + if (error.name === 'NotFoundError') { console.log(`Package info not found, ignoring package ${name}`); return; } diff --git a/packages/cli/src/lib/versioning/packages.test.ts b/packages/cli/src/lib/versioning/packages.test.ts index 784be60632..5af040809a 100644 --- a/packages/cli/src/lib/versioning/packages.test.ts +++ b/packages/cli/src/lib/versioning/packages.test.ts @@ -19,7 +19,7 @@ import path from 'path'; import * as runObj from '../run'; import { paths } from '../paths'; import { fetchPackageInfo, mapDependencies } from './packages'; -import { NotFoundError } from '@backstage/backend-common'; +import { NotFoundError } from '../errors'; describe('fetchPackageInfo', () => { afterEach(() => {