From b4d3213c289666694a54c7424bb41548e68f5398 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jefferson=20Gir=C3=A3o?= Date: Tue, 4 Feb 2020 10:52:32 +0100 Subject: [PATCH] chore: linter dependencies --- backend/inventory/app/server.go | 2 +- backend/inventory/app/server_test.go | 20 ++++++++++++++++++++ backend/inventory/go.mod | 3 +++ 3 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 backend/inventory/app/server_test.go diff --git a/backend/inventory/app/server.go b/backend/inventory/app/server.go index 5931dceb38..c03697898e 100644 --- a/backend/inventory/app/server.go +++ b/backend/inventory/app/server.go @@ -12,5 +12,5 @@ type Server struct { // GetEntity returns an inventory Entitity with the selected facts func (s *Server) GetEntity(ctx context.Context, req *pb.GetEntityRequest) (*pb.GetEntityReply, error) { - return &pb.GetEntityReply{}, nil + return &pb.GetEntityReply{Entity: req.GetEntity()}, nil } diff --git a/backend/inventory/app/server_test.go b/backend/inventory/app/server_test.go new file mode 100644 index 0000000000..c8b6404532 --- /dev/null +++ b/backend/inventory/app/server_test.go @@ -0,0 +1,20 @@ +package app + +import ( + "context" + "testing" + + pb "github.com/spotify/backstage/inventory/protos" +) + +func TestServer(t *testing.T) { + s := Server{} + req := &pb.GetEntityRequest{Entity: &pb.Entity{Kind: "test", Id: "test"}} + resp, err := s.GetEntity(context.Background(), req) + if err != nil { + t.Errorf("ServerTest(GetEntity) got unexpected error") + } + if resp.GetEntity().GetId() != req.GetEntity().GetId() { + t.Errorf("ServerTest(GetEntity) got %v, wanted %v", resp.GetEntity().GetId(), req.GetEntity().GetId()) + } +} diff --git a/backend/inventory/go.mod b/backend/inventory/go.mod index 790fbbccfd..e3246ea575 100644 --- a/backend/inventory/go.mod +++ b/backend/inventory/go.mod @@ -5,5 +5,8 @@ go 1.12 require ( github.com/golang/protobuf v1.3.2 go.etcd.io/bbolt v1.3.3 + golang.org/x/lint v0.0.0-20190313153728-d0100b6bd8b3 // indirect + golang.org/x/tools v0.0.0-20190524140312-2c0ae7006135 // indirect google.golang.org/grpc v1.27.0 + honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc // indirect )