api report and minor fixes

Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
This commit is contained in:
Vincenzo Scamporlino
2022-04-05 16:05:25 +02:00
parent 173aadff5b
commit b4af8664b5
8 changed files with 28 additions and 15 deletions
@@ -40,11 +40,11 @@ export async function createRouter(
const { jenkinsInfoProvider, permissions, logger } = options;
let permissionEvaluator: PermissionEvaluator | undefined;
if (permissions?.hasOwnProperty('query')) {
if (permissions && 'query' in permissions) {
permissionEvaluator = permissions as PermissionEvaluator;
} else {
logger.warn(
'PermissionAuthorizer is deprecated. Please use PermissionEvaluator instead of PermissionAuthorizer in your jenkins.ts',
'PermissionAuthorizer is deprecated. Please use an instance of PermissionEvaluator instead of PermissionAuthorizer in PluginEnvironment#permissions',
);
permissionEvaluator = permissions
? toPermissionEvaluator(permissions)