From 88da0bcff21a9f83b81c49c7eb9b5ac96435a64e Mon Sep 17 00:00:00 2001 From: Kurt King Date: Thu, 9 Mar 2023 16:18:32 -0700 Subject: [PATCH 1/2] add plugId property Signed-off-by: Kurt King --- docs/plugins/feature-flags.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/plugins/feature-flags.md b/docs/plugins/feature-flags.md index a572143d6e..d6847d3f65 100644 --- a/docs/plugins/feature-flags.md +++ b/docs/plugins/feature-flags.md @@ -37,7 +37,12 @@ Defining feature flag in the application is done by adding feature flags in`feat const app = createApp({ // ... featureFlags: [ - { name: 'tech-radar', description: 'Enables the tech radar plugin' }, + // pluginId can be left empty for feature flags used in the application. It is required for feature flags used in plugins + { + pluginId: '', + name: 'tech-radar', + description: 'Enables the tech radar plugin', + }, ], // ... }); From 0708a169de2bb16e787912cef8cc086ddb7e842c Mon Sep 17 00:00:00 2001 From: Kurt King Date: Thu, 9 Mar 2023 16:20:46 -0700 Subject: [PATCH 2/2] move comment after prettier ran Signed-off-by: Kurt King --- docs/plugins/feature-flags.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/plugins/feature-flags.md b/docs/plugins/feature-flags.md index d6847d3f65..7b7a6c1435 100644 --- a/docs/plugins/feature-flags.md +++ b/docs/plugins/feature-flags.md @@ -37,9 +37,8 @@ Defining feature flag in the application is done by adding feature flags in`feat const app = createApp({ // ... featureFlags: [ - // pluginId can be left empty for feature flags used in the application. It is required for feature flags used in plugins { - pluginId: '', + pluginId: '', // pluginId is required for feature flags in plugins. It can be left blank for a feature flag leveraged in the application. name: 'tech-radar', description: 'Enables the tech radar plugin', },