Modify tech insights lifecycle queries performance

Modifies database cleanup to remove all facts for entities instead of hand-picked ones only. Improves query execution a lot in large datasets.

Changes semantics of the lifecycle deletion logic slightly for cases were historical entities/facts, that are , not present in the application anymore, were kept forever instead of being cleaned up. The new implementation is more along the expected lines.

Signed-off-by: Jussi Hallila <jussi@hallila.com>

plugins/tech-insights-backend/src/service/persistence/TechInsightsDatabase.ts

@@ -114,10 +114,10 @@ export class TechInsightsDatabase implements TechInsightsStore {
 
       if (lifecycle && isTtl(lifecycle)) {
         const expiration = DateTime.now().minus(lifecycle.timeToLive);
-        await this.deleteExpiredFactsByDate(tx, factRows, expiration);
+        await this.deleteExpiredFactsByDate(tx, id, expiration);
       }
       if (lifecycle && isMaxItems(lifecycle)) {
-        await this.deleteExpiredFactsByNumber(tx, factRows, lifecycle.maxItems);
+        await this.deleteExpiredFactsByNumber(tx, id, lifecycle.maxItems);
       }
     });
   }
@@ -195,13 +195,13 @@ export class TechInsightsDatabase implements TechInsightsStore {
 
   private async deleteExpiredFactsByDate(
     tx: Transaction,
-    factRows: { id: string; entity: string }[],
+    factRetrieverId: string,
     timestamp: DateTime,
   ) {
     await tx<RawDbFactRow>('facts')
-      .whereIn(
-        ['id', 'entity'],
-        factRows.map(it => [it.id, it.entity]),
+      .where({ id: factRetrieverId })
+      .and.whereIn('entity', db =>
+        db.distinct('entity').where({ id: factRetrieverId }),
       )
       .and.where('timestamp', '<', timestamp.toISO())
       .delete();
@@ -209,13 +209,13 @@ export class TechInsightsDatabase implements TechInsightsStore {
 
   private async deleteExpiredFactsByNumber(
     tx: Transaction,
-    factRows: { id: string; entity: string }[],
+    factRetrieverId: string,
     maxItems: number,
   ) {
     const deletables = await tx<RawDbFactRow>('facts')
-      .whereIn(
-        ['id', 'entity'],
-        factRows.map(it => [it.id, it.entity]),
+      .where({ id: factRetrieverId })
+      .and.whereIn('entity', db =>
+        db.distinct('entity').where({ id: factRetrieverId }),
       )
       .and.leftJoin(
         joinTable =>