paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 32 Packages Projects Releases Wiki Activity

Modify tech insights lifecycle queries performance

Browse Source 
Modifies database cleanup to remove all facts for entities instead of hand-picked ones only. Improves query execution a lot in large datasets.

Changes semantics of the lifecycle deletion logic slightly for cases were historical entities/facts, that are , not present in the application anymore, were kept forever instead of being cleaned up. The new implementation is more along the expected lines.

Signed-off-by: Jussi Hallila <jussi@hallila.com>
This commit is contained in:
Jussi Hallila
2023-01-13 17:24:33 +01:00
parent c0765bf52b
commit b48317cfc6
2 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/unlucky-zebras-scream.md
+6
View File
@@ -0,0 +1,6 @@
---
'@backstage/plugin-tech-insights-backend': patch
---
Modifies database cleanup to remove all facts for entities instead of hand-picked ones only. Improves query execution a lot in large datasets.
Changes semantics of the lifecycle deletion logic slightly for cases were historical entities/facts, that are , not present in the application anymore, were kept forever instead of being cleaned up. The new implementation is more along the expected lines.
plugins/tech-insights-backend/src/service/persistence/TechInsightsDatabase.ts
+10 -10
View File
@@ -114,10 +114,10 @@ export class TechInsightsDatabase implements TechInsightsStore {
if (lifecycle && isTtl(lifecycle)) {
const expiration = DateTime.now().minus(lifecycle.timeToLive);
await this.deleteExpiredFactsByDate(tx, factRows, expiration);
await this.deleteExpiredFactsByDate(tx, id, expiration);
}
if (lifecycle && isMaxItems(lifecycle)) {
await this.deleteExpiredFactsByNumber(tx, factRows, lifecycle.maxItems);
await this.deleteExpiredFactsByNumber(tx, id, lifecycle.maxItems);
}
});
}
@@ -195,13 +195,13 @@ export class TechInsightsDatabase implements TechInsightsStore {
private async deleteExpiredFactsByDate(
tx: Transaction,
factRows: { id: string; entity: string }[],
factRetrieverId: string,
timestamp: DateTime,
) {
await tx<RawDbFactRow>('facts')
.whereIn(
['id', 'entity'],
factRows.map(it => [it.id, it.entity]),
.where({ id: factRetrieverId })
.and.whereIn('entity', db =>
db.distinct('entity').where({ id: factRetrieverId }),
)
.and.where('timestamp', '<', timestamp.toISO())
.delete();
@@ -209,13 +209,13 @@ export class TechInsightsDatabase implements TechInsightsStore {
private async deleteExpiredFactsByNumber(
tx: Transaction,
factRows: { id: string; entity: string }[],
factRetrieverId: string,
maxItems: number,
) {
const deletables = await tx<RawDbFactRow>('facts')
.whereIn(
['id', 'entity'],
factRows.map(it => [it.id, it.entity]),
.where({ id: factRetrieverId })
.and.whereIn('entity', db =>
db.distinct('entity').where({ id: factRetrieverId }),
)
.and.leftJoin(
joinTable =>