From b4520883c6ecb43eacfd7c2e9fd13b29d6a74e26 Mon Sep 17 00:00:00 2001 From: Brian Fletcher Date: Mon, 14 Oct 2024 13:38:08 +0100 Subject: [PATCH] Fix Dockerfile deprecated syntax. ``` 1 warning found (use docker --debug to expand): - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 48) ``` Signed-off-by: Brian Fletcher --- .changeset/shaggy-weeks-hunt.md | 5 +++++ docs/deployment/docker.md | 4 ++-- .../templates/default-app/packages/backend/Dockerfile | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 .changeset/shaggy-weeks-hunt.md diff --git a/.changeset/shaggy-weeks-hunt.md b/.changeset/shaggy-weeks-hunt.md new file mode 100644 index 0000000000..2b007f6944 --- /dev/null +++ b/.changeset/shaggy-weeks-hunt.md @@ -0,0 +1,5 @@ +--- +'@backstage/create-app': patch +--- + +Tweak `Dockerfile` to fix deprecated syntax. diff --git a/docs/deployment/docker.md b/docs/deployment/docker.md index 7a17f09ad6..afab8ef54d 100644 --- a/docs/deployment/docker.md +++ b/docs/deployment/docker.md @@ -90,7 +90,7 @@ COPY --chown=node:node .yarnrc.yml ./ ENV NODE_ENV=production # This disables node snapshot for Node 20 to work with the Scaffolder -ENV NODE_OPTIONS "--no-node-snapshot" +ENV NODE_OPTIONS="--no-node-snapshot" # Copy repo skeleton first, to avoid unnecessary docker cache invalidation. # The skeleton contains the package.json of each package in the monorepo, @@ -287,7 +287,7 @@ COPY --chown=node:node examples ./examples ENV NODE_ENV=production # This disables node snapshot for Node 20 to work with the Scaffolder -ENV NODE_OPTIONS "--no-node-snapshot" +ENV NODE_OPTIONS="--no-node-snapshot" CMD ["node", "packages/backend", "--config", "app-config.yaml", "--config", "app-config.production.yaml"] ``` diff --git a/packages/create-app/templates/default-app/packages/backend/Dockerfile b/packages/create-app/templates/default-app/packages/backend/Dockerfile index 09024eb44f..6a4c257afb 100644 --- a/packages/create-app/templates/default-app/packages/backend/Dockerfile +++ b/packages/create-app/templates/default-app/packages/backend/Dockerfile @@ -45,7 +45,7 @@ COPY --chown=node:node .yarnrc.yml ./ ENV NODE_ENV=production # This disables node snapshot for Node 20 to work with the Scaffolder -ENV NODE_OPTIONS "--no-node-snapshot" +ENV NODE_OPTIONS="--no-node-snapshot" # Copy repo skeleton first, to avoid unnecessary docker cache invalidation. # The skeleton contains the package.json of each package in the monorepo,