Merge pull request #31166 from schultzp2020/constructor-parameters

refactor: convert constructor parameter properties for erasableSyntaxOnly compatibility

plugins/scaffolder-node/src/actions/loggerToWinstonLogger.ts

@@ -20,11 +20,11 @@ import { Logger as WinstonLogger, createLogger } from 'winston';
 import Transport, { TransportStreamOptions } from 'winston-transport';
 
 class BackstageLoggerTransport extends Transport {
-  constructor(
-    private readonly backstageLogger: LoggerService,
-    opts?: TransportStreamOptions,
-  ) {
+  private readonly backstageLogger: LoggerService;
+
+  constructor(backstageLogger: LoggerService, opts?: TransportStreamOptions) {
     super(opts);
+    this.backstageLogger = backstageLogger;
   }
 
   log(info: unknown, callback: VoidFunction) {

plugins/scaffolder-node/src/scm/git.ts

@@ -79,13 +79,18 @@ export class Git {
     [x: string]: string;
   };
 
-  private constructor(
-    private readonly config: {
-      onAuth: AuthCallback;
-      token?: string;
-      logger?: LoggerService;
-    },
-  ) {
+  private readonly config: {
+    onAuth: AuthCallback;
+    token?: string;
+    logger?: LoggerService;
+  };
+
+  private constructor(config: {
+    onAuth: AuthCallback;
+    token?: string;
+    logger?: LoggerService;
+  }) {
+    this.config = config;
     this.onAuth = config.onAuth;
 
     this.headers = {