fix modal behaviour

Signed-off-by: Bruno Fuzetti Penso <bruno.penso@gmail.com>

plugins/tech-radar/src/components/RadarDescription/RadarDescription.tsx

@@ -35,12 +35,12 @@ const RadarDescription = (props: Props): JSX.Element => {
 
   const handleClick = () => {
     onClose();
-    if (url) {
-      if (urlTarget) {
-        window.open(url, urlTarget);
-      } else {
-        window.location.href = url;
-      }
+    if (urlTarget) {
+      console.log('with target' + urlTarget)
+      window.open(url, urlTarget);
+    } else {
+      console.log('no target' + urlTarget)
+      window.location.href = url;
     }
   };
 
@@ -52,13 +52,12 @@ const RadarDescription = (props: Props): JSX.Element => {
       <DialogContent dividers>
         <MarkdownContent content={description} />
       </DialogContent>
-      {url && (
+      {(url && url !== '#') && (
         <DialogActions>
           <Button
             onClick={handleClick}
             color="primary"
             startIcon={<LinkIcon />}
-            href={url}
           >
             LEARN MORE
           </Button>

plugins/tech-radar/src/components/RadarEntry/RadarEntry.tsx

@@ -110,6 +110,7 @@ const RadarEntry = (props: Props): JSX.Element => {
           title={title ? title : 'no title'}
           description={description ? description : 'no description'}
           url={url}
+          urlTarget={urlTarget}
         />
       )}
       {description ? (

plugins/tech-radar/src/components/RadarPlot/RadarPlot.tsx

@@ -73,6 +73,7 @@ const RadarPlot = (props: Props): JSX.Element => {
             color={entry.color || ''}
             value={(entry?.index || 0) + 1}
             url={entry.url}
+            urlTarget={entry.urlTarget}
             description={entry.description}
             moved={entry.moved}
             title={entry.title}

plugins/tech-radar/src/sample.ts

@@ -107,14 +107,14 @@ entries.push({
     {
       moved: 0,
       ringId: 'use',
-      date: new Date('2020-08-06'),
+      date: new Date('2020-08-06')
     },
   ],
   url: '#',
   key: 'code-reviews',
   id: 'code-reviews',
   title: 'Code Reviews',
-  quadrant: 'process',
+  quadrant: 'process'
 });
 entries.push({
   timeline: [
@@ -162,10 +162,11 @@ entries.push({
     {
       ringId: 'use',
       date: new Date('2020-08-06'),
-      description: 'test description'
+      description: 'description'
     },
   ],
-  url: '#',
+  url: 'https://github.com',
+  urlTarget: '_blank',
   key: 'github-actions',
   id: 'github-actions',
   title: 'GitHub Actions',

plugins/tech-radar/src/utils/components.tsx

@@ -29,7 +29,7 @@ export const WithLink = ({
   className,
   children,
 }: WithLinkProps): JSX.Element =>
-  url ? (
+  (url && url!== '#') ? (
     <Link target={urlTarget} className={className} to={url}>
       {children}
     </Link>