From b20e2e16fd9dae60d3cee94a80e31af0a4f2113e Mon Sep 17 00:00:00 2001 From: Tracey Radcliffe Date: Tue, 14 Mar 2023 10:25:28 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Johan Haals Signed-off-by: Tracey Radcliffe --- .changeset/new-pigs-jam.md | 2 +- .../package.json | 2 +- .../src/actions/confluence/confluenceToMarkdown.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.changeset/new-pigs-jam.md b/.changeset/new-pigs-jam.md index ed9c39297a..4c7f74d17f 100644 --- a/.changeset/new-pigs-jam.md +++ b/.changeset/new-pigs-jam.md @@ -1,5 +1,5 @@ --- -'@backstage/plugin-scaffolder-backend-module-confluence-to-markdowwn': patch +'@backstage/plugin-scaffolder-backend-module-confluence-to-markdowwn': minor --- Created new action for converting confluence docs to Markdown, to be pushed to GitHub repos onboarded onto Techdocs diff --git a/plugins/scaffolder-backend-module-confluence-to-markdowwn/package.json b/plugins/scaffolder-backend-module-confluence-to-markdowwn/package.json index cc445108c3..6ae6ea8688 100644 --- a/plugins/scaffolder-backend-module-confluence-to-markdowwn/package.json +++ b/plugins/scaffolder-backend-module-confluence-to-markdowwn/package.json @@ -1,5 +1,5 @@ { - "name": "@backstage/plugin-scaffolder-backend-module-confluence-to-markdowwn", + "name": "@backstage/plugin-scaffolder-backend-module-confluence-to-markdown", "description": "The confluence-to-markdowwn module for @backstage/plugin-scaffolder-backend", "version": "0.0.0", "main": "src/index.ts", diff --git a/plugins/scaffolder-backend-module-confluence-to-markdowwn/src/actions/confluence/confluenceToMarkdown.ts b/plugins/scaffolder-backend-module-confluence-to-markdowwn/src/actions/confluence/confluenceToMarkdown.ts index 1ded6e90f3..62bebb752f 100644 --- a/plugins/scaffolder-backend-module-confluence-to-markdowwn/src/actions/confluence/confluenceToMarkdown.ts +++ b/plugins/scaffolder-backend-module-confluence-to-markdowwn/src/actions/confluence/confluenceToMarkdown.ts @@ -72,7 +72,7 @@ export const createConfluenceToMarkdownAction = (options: { }, async handler(ctx) { const { confluenceUrls, repoUrl } = ctx.input; - const parsedRepoUrl = parseGitUrl(`${repoUrl}`); + const parsedRepoUrl = parseGitUrl(repoUrl); const filePathToMkdocs = parsedRepoUrl.filepath.substring( 0, parsedRepoUrl.filepath.lastIndexOf('/') + 1,