From b08dbb103552ad16064c0c84bad975311152320d Mon Sep 17 00:00:00 2001
From: Mike Lewis <mtlewis@users.noreply.github.com>
Date: Wed, 24 Nov 2021 14:18:11 +0000
Subject: [PATCH] permission-node: destructure options inside function to
 simplify api-report

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
---
 plugins/permission-node/api-report.md         |  6 +--
 .../src/integration/createConditionExports.ts | 38 ++++++++++---------
 2 files changed, 21 insertions(+), 23 deletions(-)

diff --git a/plugins/permission-node/api-report.md b/plugins/permission-node/api-report.md
index 95e1eb0711..e5fe9a7087 100644
--- a/plugins/permission-node/api-report.md
+++ b/plugins/permission-node/api-report.md
@@ -57,11 +57,7 @@ export type ConditionTransformer<TQuery> = (
 export const createConditionExports: <
   TResource,
   TRules extends Record<string, PermissionRule<TResource, any, unknown[]>>,
->({
-  pluginId,
-  resourceType,
-  rules,
-}: {
+>(options: {
   pluginId: string;
   resourceType: string;
   rules: TRules;
diff --git a/plugins/permission-node/src/integration/createConditionExports.ts b/plugins/permission-node/src/integration/createConditionExports.ts
index d7f8c675d2..d69064a56c 100644
--- a/plugins/permission-node/src/integration/createConditionExports.ts
+++ b/plugins/permission-node/src/integration/createConditionExports.ts
@@ -63,11 +63,7 @@ export type Conditions<
 export const createConditionExports = <
   TResource,
   TRules extends Record<string, PermissionRule<TResource, any>>,
->({
-  pluginId,
-  resourceType,
-  rules,
-}: {
+>(options: {
   pluginId: string;
   resourceType: string;
   rules: TRules;
@@ -78,17 +74,23 @@ export const createConditionExports = <
     resourceType: string;
     conditions: PermissionCriteria<PermissionCondition>;
   };
-} => ({
-  conditions: Object.entries(rules).reduce(
-    (acc, [key, rule]) => ({
-      ...acc,
-      [key]: createConditionFactory(rule),
+} => {
+  const { pluginId, resourceType, rules } = options;
+
+  return {
+    conditions: Object.entries(rules).reduce(
+      (acc, [key, rule]) => ({
+        ...acc,
+        [key]: createConditionFactory(rule),
+      }),
+      {} as Conditions<TRules>,
+    ),
+    createConditions: (
+      conditions: PermissionCriteria<PermissionCondition>,
+    ) => ({
+      pluginId,
+      resourceType,
+      conditions,
     }),
-    {} as Conditions<TRules>,
-  ),
-  createConditions: (conditions: PermissionCriteria<PermissionCondition>) => ({
-    pluginId,
-    resourceType,
-    conditions,
-  }),
-});
+  };
+};