Apply suggestions from code review

Co-authored-by: Camila Belo <camilaibs@gmail.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
This commit is contained in:
Emma Indal
2023-02-01 12:58:54 +01:00
parent c3798fd6bd
commit b031b821d5
4 changed files with 53 additions and 45 deletions
+2 -2
View File
@@ -5,6 +5,6 @@
'@backstage/plugin-search-react': patch
---
`ListItem` wrapper component moved to `SearchResultListItemExtension` for all `*SearchResultListItems`. This is to make sure the list only contains list elements.
`ListItem` wrapper component moved to `SearchResultListItemExtension` for all `*SearchResultListItems` that are exported as extensions. This is to make sure the list only contains list elements.
Note: If you have implemented a custom result list item, you can remove the list item wrapper to avoid duplicated `<li>` elements.
Note: If you have implemented a custom result list item, we recommend you to remove the list item wrapper to avoid nested `<li>` elements.