From d367f63b53943462f458e8c8178b77b0d63215d9 Mon Sep 17 00:00:00 2001
From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue, 23 Mar 2021 08:26:26 +0000
Subject: [PATCH] chore(deps): bump helmet from 4.0.0 to 4.4.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Bumps [helmet](https://github.com/helmetjs/helmet) from 4.0.0 to 4.4.1.
- [Release notes](https://github.com/helmetjs/helmet/releases)
- [Changelog](https://github.com/helmetjs/helmet/blob/main/CHANGELOG.md)
- [Commits](https://github.com/helmetjs/helmet/compare/v4.0.0...v4.4.1)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
---
 .changeset/grumpy-games-shop.md                       |  5 +++++
 .../src/service/lib/ServiceBuilderImpl.ts             | 11 ++---------
 yarn.lock                                             |  6 +++---
 3 files changed, 10 insertions(+), 12 deletions(-)
 create mode 100644 .changeset/grumpy-games-shop.md

diff --git a/.changeset/grumpy-games-shop.md b/.changeset/grumpy-games-shop.md
new file mode 100644
index 0000000000..7426786f89
--- /dev/null
+++ b/.changeset/grumpy-games-shop.md
@@ -0,0 +1,5 @@
+---
+'@backstage/backend-common': patch
+---
+
+remove use of deprecated type HelmetOptions
diff --git a/packages/backend-common/src/service/lib/ServiceBuilderImpl.ts b/packages/backend-common/src/service/lib/ServiceBuilderImpl.ts
index 07da975184..c17545779a 100644
--- a/packages/backend-common/src/service/lib/ServiceBuilderImpl.ts
+++ b/packages/backend-common/src/service/lib/ServiceBuilderImpl.ts
@@ -18,7 +18,7 @@ import { Config } from '@backstage/config';
 import compression from 'compression';
 import cors from 'cors';
 import express, { Router } from 'express';
-import helmet, { HelmetOptions } from 'helmet';
+import helmet from 'helmet';
 import * as http from 'http';
 import stoppable from 'stoppable';
 import { Logger } from 'winston';
@@ -195,14 +195,7 @@ export class ServiceBuilderImpl implements ServiceBuilder {
     });
   }
 
-  private getOptions(): {
-    port: number;
-    host: string;
-    logger: Logger;
-    corsOptions?: cors.CorsOptions;
-    httpsSettings?: HttpsSettings;
-    helmetOptions: HelmetOptions;
-  } {
+  private getOptions() {
     return {
       port: this.port ?? DEFAULT_PORT,
       host: this.host ?? DEFAULT_HOST,
diff --git a/yarn.lock b/yarn.lock
index 370f3f5a7f..6cc6ab938d 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -14929,9 +14929,9 @@ headers-utils@^1.2.0:
   integrity sha512-4/BMXcWrJErw7JpM87gF8MNEXcIMLzepYZjNRv/P9ctgupl2Ywa3u1PgHtNhSRq84bHH9Ndlkdy7bSi+bZ9I9A==
 
 helmet@^4.0.0:
-  version "4.0.0"
-  resolved "https://registry.npmjs.org/helmet/-/helmet-4.0.0.tgz#34c187894ed001834f997c688f2b2df19846b193"
-  integrity sha512-HyoRKKHhWhO6+EBfgRLkuZR4/+NXc1nJB7x0bWwW89i9eoPciK0qUqyZNOA/zowpgrW9C4+J5toqMkZrpBOlkg==
+  version "4.4.1"
+  resolved "https://registry.npmjs.org/helmet/-/helmet-4.4.1.tgz#a17e1444d81d7a83ddc6e6f9bc6e2055b994efe7"
+  integrity sha512-G8tp0wUMI7i8wkMk2xLcEvESg5PiCitFMYgGRc/PwULB0RVhTP5GFdxOwvJwp9XVha8CuS8mnhmE8I/8dx/pbw==
 
 hex-color-regex@^1.1.0:
   version "1.1.0"