From af4c1469c27adf1771b6929b6d7f6fbf30437ffa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Carl-Erik=20Bergstr=C3=B6m?= <cbergstrom@spotify.com>
Date: Mon, 9 Sep 2024 14:10:39 +0200
Subject: [PATCH] fix: support menu items should not be buttons in favour of
 links
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Carl-Erik Bergström <cbergstrom@spotify.com>
---
 .changeset/early-cats-deliver.md                             | 5 +++++
 .../src/components/SupportButton/SupportButton.tsx           | 3 ++-
 2 files changed, 7 insertions(+), 1 deletion(-)
 create mode 100644 .changeset/early-cats-deliver.md

diff --git a/.changeset/early-cats-deliver.md b/.changeset/early-cats-deliver.md
new file mode 100644
index 0000000000..77811444dc
--- /dev/null
+++ b/.changeset/early-cats-deliver.md
@@ -0,0 +1,5 @@
+---
+'@backstage/core-components': patch
+---
+
+Support menu items should not be buttons in favour of links
diff --git a/packages/core-components/src/components/SupportButton/SupportButton.tsx b/packages/core-components/src/components/SupportButton/SupportButton.tsx
index 8626353dd1..9e51e23119 100644
--- a/packages/core-components/src/components/SupportButton/SupportButton.tsx
+++ b/packages/core-components/src/components/SupportButton/SupportButton.tsx
@@ -67,7 +67,7 @@ const SupportLink = ({ link }: { link: SupportItemLink }) => (
 
 const SupportListItem = ({ item }: { item: SupportItem }) => {
   return (
-    <MenuItem>
+    <MenuItem button={false}>
       <ListItemIcon>
         <SupportIcon icon={item.icon} />
       </ListItemIcon>
@@ -161,6 +161,7 @@ export function SupportButton(props: SupportButtonProps) {
           )}
           {React.Children.map(children, (child, i) => (
             <MenuItem
+              button={false}
               alignItems="flex-start"
               key={`child-${i}`}
               className={classes.menuItem}