Introduce PermissionMessageBatch utility type. Rename Identified type to IdentifiedPermissionMessage.

Co-authored-by: Mike Lewis <mtlewis@users.noreply.github.com>
Signed-off-by: Joe Porpeglia <josephp@spotify.com>

plugins/permission-node/src/ServerPermissionClient.test.ts

@@ -16,7 +16,7 @@
 
 import { ServerPermissionClient } from './ServerPermissionClient';
 import {
-  Identified,
+  IdentifiedPermissionMessage,
   AuthorizeQuery,
   AuthorizeResult,
   createPermission,
@@ -32,10 +32,12 @@ import { RestContext, rest } from 'msw';
 
 const server = setupServer();
 const mockAuthorizeHandler = jest.fn((req, res, { json }: RestContext) => {
-  const responses = req.body.items.map((r: Identified<AuthorizeQuery>) => ({
-    id: r.id,
-    result: AuthorizeResult.ALLOW,
-  }));
+  const responses = req.body.items.map(
+    (r: IdentifiedPermissionMessage<AuthorizeQuery>) => ({
+      id: r.id,
+      result: AuthorizeResult.ALLOW,
+    }),
+  );
 
   return res(json({ items: responses }));
 });

plugins/permission-node/src/integration/createPermissionIntegrationRouter.ts

@@ -21,7 +21,7 @@ import { InputError } from '@backstage/errors';
 import { errorHandler } from '@backstage/backend-common';
 import {
   AuthorizeResult,
-  Identified,
+  IdentifiedPermissionMessage,
   PermissionCondition,
   PermissionCriteria,
 } from '@backstage/plugin-permission-common';
@@ -67,7 +67,7 @@ const applyConditionsRequestSchema = z.object({
  *
  * @public
  */
-export type ApplyConditionsRequestEntry = Identified<{
+export type ApplyConditionsRequestEntry = IdentifiedPermissionMessage<{
   resourceRef: string;
   resourceType: string;
   conditions: PermissionCriteria<PermissionCondition>;
@@ -88,7 +88,8 @@ export type ApplyConditionsRequest = {
  *
  * @public
  */
-export type ApplyConditionsResponseEntry = Identified<DefinitivePolicyDecision>;
+export type ApplyConditionsResponseEntry =
+  IdentifiedPermissionMessage<DefinitivePolicyDecision>;
 
 /**
  * A batch of {@link ApplyConditionsResponseEntry} objects.