Fix linting errors after #13392

Signed-off-by: Fredrik Adelöw <freben@gmail.com>

plugins/sonarqube-backend/src/service/router.test.ts

@@ -69,8 +69,8 @@ describe('createRouter', () => {
           instanceKey: DUMMY_INSTANCE_KEY,
         })
         .send();
-      expect(getFindingsMock).toBeCalledTimes(1);
-      expect(getFindingsMock).toBeCalledWith({
+      expect(getFindingsMock).toHaveBeenCalledTimes(1);
+      expect(getFindingsMock).toHaveBeenCalledWith({
         componentKey: DUMMY_COMPONENT_KEY,
         instanceName: DUMMY_INSTANCE_KEY,
       });
@@ -103,8 +103,8 @@ describe('createRouter', () => {
         })
         .send();
 
-      expect(getFindingsMock).toBeCalledTimes(1);
-      expect(getFindingsMock).toBeCalledWith({
+      expect(getFindingsMock).toHaveBeenCalledTimes(1);
+      expect(getFindingsMock).toHaveBeenCalledWith({
         componentKey: DUMMY_COMPONENT_KEY,
         instanceName: undefined,
       });
@@ -123,8 +123,8 @@ describe('createRouter', () => {
           instanceKey: DUMMY_INSTANCE_KEY,
         })
         .send();
-      expect(getBaseUrlMock).toBeCalledTimes(1);
-      expect(getBaseUrlMock).toBeCalledWith({
+      expect(getBaseUrlMock).toHaveBeenCalledTimes(1);
+      expect(getBaseUrlMock).toHaveBeenCalledWith({
         instanceName: DUMMY_INSTANCE_KEY,
       });
       expect(response.status).toEqual(200);
@@ -134,8 +134,8 @@ describe('createRouter', () => {
     it('query default instance when instanceKey not provided', async () => {
       getBaseUrlMock.mockReturnValue({ baseUrl: DUMMY_INSTANCE_URL });
       const response = await request(app).get('/instanceUrl').send();
-      expect(getBaseUrlMock).toBeCalledTimes(1);
-      expect(getBaseUrlMock).toBeCalledWith({
+      expect(getBaseUrlMock).toHaveBeenCalledTimes(1);
+      expect(getBaseUrlMock).toHaveBeenCalledWith({
         instanceName: undefined,
       });
       expect(response.status).toEqual(200);

plugins/sonarqube-backend/src/service/sonarqubeInfoProvider.test.ts

@@ -129,7 +129,7 @@ describe('SonarqubeConfig', () => {
             },
           }),
         ),
-      ).toThrowError(Error);
+      ).toThrow(Error);
     });
 
     it('Throw an error if default config is partially provided', async () => {
@@ -141,7 +141,7 @@ describe('SonarqubeConfig', () => {
             },
           }),
         ),
-      ).toThrowError(Error);
+      ).toThrow(Error);
     });
   });
 
@@ -208,7 +208,7 @@ describe('SonarqubeConfig', () => {
 
       expect(() =>
         config.getInstanceConfig({ sonarqubeName: 'default' }),
-      ).toThrowError(Error);
+      ).toThrow(Error);
     });
 
     it('Throw an error if named instance could not be found', async () => {
@@ -218,7 +218,7 @@ describe('SonarqubeConfig', () => {
 
       expect(() =>
         config.getInstanceConfig({ sonarqubeName: 'other' }),
-      ).toThrowError(Error);
+      ).toThrow(Error);
     });
   });
 });