From 5f9877b6468fb673744b1227a7013ca1452d7199 Mon Sep 17 00:00:00 2001 From: Heikki Hellgren Date: Tue, 2 Apr 2024 10:32:05 +0300 Subject: [PATCH 1/2] fix: allow unauthenticated signals connection to fix 401 the signals handles authentication itself in the middleware thus we should allow unauthenticated requests to pass through Signed-off-by: Heikki Hellgren --- .changeset/ninety-toys-bake.md | 5 +++++ plugins/signals-backend/src/plugin.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/ninety-toys-bake.md diff --git a/.changeset/ninety-toys-bake.md b/.changeset/ninety-toys-bake.md new file mode 100644 index 0000000000..d3f8180a66 --- /dev/null +++ b/.changeset/ninety-toys-bake.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-signals-backend': patch +--- + +Fix unauthorized signals connection by allowing unauthenticated requests diff --git a/plugins/signals-backend/src/plugin.ts b/plugins/signals-backend/src/plugin.ts index d20506f004..dc464e5c54 100644 --- a/plugins/signals-backend/src/plugin.ts +++ b/plugins/signals-backend/src/plugin.ts @@ -58,7 +58,7 @@ export const signalsPlugin = createBackendPlugin({ }), ); httpRouter.addAuthPolicy({ - path: '/health', + path: '*', allow: 'unauthenticated', }); }, From 6ff7cd8572b41023c329e0e335e333c571c6a6bd Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Tue, 2 Apr 2024 11:42:29 +0200 Subject: [PATCH 2/2] Update plugins/signals-backend/src/plugin.ts Signed-off-by: Patrik Oldsberg --- plugins/signals-backend/src/plugin.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/signals-backend/src/plugin.ts b/plugins/signals-backend/src/plugin.ts index dc464e5c54..3e00c00a34 100644 --- a/plugins/signals-backend/src/plugin.ts +++ b/plugins/signals-backend/src/plugin.ts @@ -58,7 +58,7 @@ export const signalsPlugin = createBackendPlugin({ }), ); httpRouter.addAuthPolicy({ - path: '*', + path: '/', allow: 'unauthenticated', }); },