From aa2a3759cc37ac52532bceabfd48276541e2887d Mon Sep 17 00:00:00 2001
From: Marley Powell <Marley.Powell@exclaimer.com>
Date: Mon, 29 Nov 2021 10:07:22 +0000
Subject: [PATCH] test: Added some unit tests for `azure-devops-utils`.

Signed-off-by: Marley Powell <Marley.Powell@exclaimer.com>
---
 .../src/utils/azure-devops-utils.test.ts      | 161 ++++++++++++++++++
 .../src/utils/azure-devops-utils.ts           |   2 +-
 2 files changed, 162 insertions(+), 1 deletion(-)
 create mode 100644 plugins/azure-devops-backend/src/utils/azure-devops-utils.test.ts

diff --git a/plugins/azure-devops-backend/src/utils/azure-devops-utils.test.ts b/plugins/azure-devops-backend/src/utils/azure-devops-utils.test.ts
new file mode 100644
index 0000000000..8aed436710
--- /dev/null
+++ b/plugins/azure-devops-backend/src/utils/azure-devops-utils.test.ts
@@ -0,0 +1,161 @@
+/*
+ * Copyright 2021 The Backstage Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import {
+  DashboardPullRequest,
+  PullRequestStatus,
+  PullRequestVoteStatus,
+} from '@backstage/plugin-azure-devops-common';
+import {
+  convertDashboardPullRequest,
+  getArtifactId,
+  getAvatarUrl,
+  getPullRequestLink,
+} from './azure-devops-utils';
+
+import { GitPullRequest } from 'azure-devops-node-api/interfaces/GitInterfaces';
+
+describe('convertDashboardPullRequest', () => {
+  it('should return DashboardPullRequest', () => {
+    const baseUrl = 'https://dev.azure.com';
+
+    const pullRequest: GitPullRequest = {
+      pullRequestId: 1,
+      title: 'Pull Request 1',
+      description: 'Test description',
+      repository: {
+        id: 'repo1',
+        name: 'azure-devops',
+        url: 'https://dev.azure.com/backstage/backstage/_apis/git/repositories/azure-devops',
+        project: {
+          name: 'backstage',
+        },
+      },
+      createdBy: {
+        id: 'user1',
+        displayName: 'User 1',
+        uniqueName: 'user1@backstage.io',
+        _links: {
+          avatar: {
+            href: 'avatar-href',
+          },
+        },
+        imageUrl: 'avatar-url',
+      },
+      reviewers: [
+        {
+          id: 'user2',
+          displayName: 'User 2',
+          _links: {
+            avatar: {
+              href: 'avatar-href',
+            },
+          },
+          isRequired: true,
+          isContainer: false,
+          vote: 10,
+        },
+      ],
+      creationDate: new Date('2021-10-15T09:30:00.0000000Z'),
+      status: PullRequestStatus.Active,
+      isDraft: false,
+      completionOptions: {},
+    };
+
+    const expectedPullRequest: DashboardPullRequest = {
+      pullRequestId: 1,
+      title: 'Pull Request 1',
+      description: 'Test description',
+      repository: {
+        id: 'repo1',
+        name: 'azure-devops',
+        url: 'https://dev.azure.com/backstage/backstage/_git/azure-devops',
+      },
+      createdBy: {
+        id: 'user1',
+        displayName: 'User 1',
+        uniqueName: 'user1@backstage.io',
+        imageUrl: 'avatar-href',
+      },
+      hasAutoComplete: true,
+      policies: [],
+      reviewers: [
+        {
+          id: 'user2',
+          displayName: 'User 2',
+          imageUrl: 'avatar-href',
+          isRequired: true,
+          isContainer: false,
+          voteStatus: PullRequestVoteStatus.Approved,
+        },
+      ],
+      creationDate: '2021-10-15T09:30:00.000Z',
+      status: PullRequestStatus.Active,
+      isDraft: false,
+      link: 'https://dev.azure.com/backstage/_git/azure-devops/pullrequest/1',
+    };
+
+    const result = convertDashboardPullRequest(pullRequest, baseUrl, []);
+    expect(result).toEqual(expectedPullRequest);
+  });
+});
+
+describe('getPullRequestLink', () => {
+  it('should return pull request link', () => {
+    const baseUrl = 'dev.azure.com';
+    const pullRequest = {
+      pullRequestId: 1,
+      repository: {
+        name: 'azure-devops',
+        project: {
+          name: 'backstage',
+        },
+      },
+    };
+    const result = getPullRequestLink(baseUrl, pullRequest);
+    expect(result).toBe(`${baseUrl}/backstage/_git/azure-devops/pullrequest/1`);
+  });
+});
+
+describe('getAvatarUrl', () => {
+  it('should return avatar href', () => {
+    const identity = {
+      _links: {
+        avatar: {
+          href: 'avatar-href',
+        },
+      },
+      imageUrl: 'avatar-url',
+    };
+    const result = getAvatarUrl(identity);
+    expect(result).toBe('avatar-href');
+  });
+
+  it('should return avatar image url', () => {
+    const identity = {
+      imageUrl: 'avatar-url',
+    };
+    const result = getAvatarUrl(identity);
+    expect(result).toBe('avatar-url');
+  });
+});
+
+describe('getArtifactId', () => {
+  it('should return artifact id', () => {
+    const result = getArtifactId('project1', 1);
+    expect(result).toBe('vstfs:///CodeReview/CodeReviewId/project1/1');
+  });
+});
diff --git a/plugins/azure-devops-backend/src/utils/azure-devops-utils.ts b/plugins/azure-devops-backend/src/utils/azure-devops-utils.ts
index 8d82f84b60..aa843e9c17 100644
--- a/plugins/azure-devops-backend/src/utils/azure-devops-utils.ts
+++ b/plugins/azure-devops-backend/src/utils/azure-devops-utils.ts
@@ -242,7 +242,7 @@ function convertRepository(repository?: GitRepository): Repository | undefined {
   return {
     id: repository.id,
     name: repository.name,
-    url: repository.url,
+    url: repository.url?.replace('_apis/git/repositories', '_git'),
   };
 }