paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 17 Packages Projects Releases Wiki Activity

encodeURI on all params in frontend api

Browse Source 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
This commit is contained in:
alde
2021-04-19 12:08:42 -04:00
committed by Fredrik Adelöw
parent 5813a89427
commit aa1812c580
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/code-coverage/src/api.ts
+7 -5
View File
@@ -76,7 +76,7 @@ export class CodeCoverageRestApi implements CodeCoverageApi {
async getCoverageForEntity(
entityName: EntityName,
): Promise<JsonCodeCoverage> {
const entity = stringifyEntityRef(entityName);
const entity = encodeURI(stringifyEntityRef(entityName));
return (await this.fetch<JsonCodeCoverage>(
`/api/code-coverage/report?entity=${entity}`,
)) as JsonCodeCoverage;
@@ -86,9 +86,11 @@ export class CodeCoverageRestApi implements CodeCoverageApi {
entityName: EntityName,
filePath: string,
): Promise<string> {
const entity = stringifyEntityRef(entityName);
const entity = encodeURI(stringifyEntityRef(entityName));
return await this.fetch<string>(
`/api/code-coverage/file-content?entity=${entity}&path=${filePath}`,
`/api/code-coverage/file-content?entity=${entity}&path=${encodeURI(
filePath,
)}`,
);
}
@@ -96,11 +98,11 @@ export class CodeCoverageRestApi implements CodeCoverageApi {
entityName: EntityName,
limit?: number,
): Promise<JsonCoverageHistory> {
const entity = stringifyEntityRef(entityName);
const entity = encodeURI(stringifyEntityRef(entityName));
const hasValidLimit = limit && limit > 0;
return (await this.fetch<JsonCoverageHistory>(
`/api/code-coverage/history?entity=${entity}${
hasValidLimit ? `&limit=${limit}` : ''
hasValidLimit ? `&limit=${encodeURI(`${limit}`)}` : ''
}`,
)) as JsonCoverageHistory;
}