Merge pull request #13228 from backstage/freben/neato

it just keeps 🧹 -ing

packages/catalog-client/api-report.md

@@ -78,7 +78,7 @@ export class CatalogClient implements CatalogApi {
     };
   });
   addLocation(
-    { type, target, dryRun }: AddLocationRequest,
+    request: AddLocationRequest,
     options?: CatalogRequestOptions,
   ): Promise<AddLocationResponse>;
   getEntities(

packages/catalog-client/src/CatalogClient.ts

@@ -272,9 +272,11 @@ export class CatalogClient implements CatalogApi {
    * {@inheritdoc CatalogApi.addLocation}
    */
   async addLocation(
-    { type = 'url', target, dryRun }: AddLocationRequest,
+    request: AddLocationRequest,
     options?: CatalogRequestOptions,
   ): Promise<AddLocationResponse> {
+    const { type = 'url', target, dryRun } = request;
+
     const response = await this.fetchApi.fetch(
       `${await this.discoveryApi.getBaseUrl('catalog')}/locations${
         dryRun ? '?dryRun=true' : ''

packages/core-plugin-api/api-report.md

@@ -649,10 +649,7 @@ export interface PluginOptionsProviderProps {
 }
 
 // @alpha
-export const PluginProvider: ({
-  children,
-  plugin,
-}: PluginOptionsProviderProps) => JSX.Element;
+export const PluginProvider: (props: PluginOptionsProviderProps) => JSX.Element;
 
 // @public
 export type ProfileInfo = {

packages/core-plugin-api/src/plugin-options/usePluginOptions.tsx

@@ -39,10 +39,11 @@ export interface PluginOptionsProviderProps {
  *
  * @alpha
  */
-export const PluginProvider = ({
-  children,
-  plugin,
-}: PluginOptionsProviderProps): JSX.Element => {
+export const PluginProvider = (
+  props: PluginOptionsProviderProps,
+): JSX.Element => {
+  const { children, plugin } = props;
+
   const { Provider } = createVersionedContext<{
     1: { plugin: BackstagePlugin | undefined };
   }>(contextKey);