From a84ddea6165612eb5e62ed68451a9e43d5c0f334 Mon Sep 17 00:00:00 2001 From: sn0wcat Date: Thu, 31 Jul 2025 11:36:33 +0200 Subject: [PATCH] chore: improved the logging message Signed-off-by: sn0wcat --- .changeset/mean-sites-cheer.md | 5 +++++ .../src/actions/gitlabPipelineTrigger.ts | 7 +++++-- 2 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 .changeset/mean-sites-cheer.md diff --git a/.changeset/mean-sites-cheer.md b/.changeset/mean-sites-cheer.md new file mode 100644 index 0000000000..a35dfb8c33 --- /dev/null +++ b/.changeset/mean-sites-cheer.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder-backend-module-gitlab': patch +--- + +The log message now indicates that the pipeline trigger token was deleted and not pipeline itself. diff --git a/plugins/scaffolder-backend-module-gitlab/src/actions/gitlabPipelineTrigger.ts b/plugins/scaffolder-backend-module-gitlab/src/actions/gitlabPipelineTrigger.ts index 41a00bc985..ccb29c1f75 100644 --- a/plugins/scaffolder-backend-module-gitlab/src/actions/gitlabPipelineTrigger.ts +++ b/plugins/scaffolder-backend-module-gitlab/src/actions/gitlabPipelineTrigger.ts @@ -156,11 +156,14 @@ export const createTriggerGitlabPipelineAction = (options: { }, }); ctx.logger.info( - `Deleted pipeline with token id ${pipelineTriggerId}.`, + // in version 18.0 of gitlab this was also deleting the pipeline + // this is a problem in gitlab which is fixed in version 18.1 + // https://gitlab.com/gitlab-org/gitlab/-/issues/546669 + `Deleted pipeline trigger token with token id: ${pipelineTriggerId}.`, ); } catch (error: any) { ctx.logger.error( - `Failed to delete pipeline with token id ${pipelineTriggerId}.`, + `Failed to delete pipeline trigger token with token id: ${pipelineTriggerId}.`, ); } }