Merge pull request #9000 from backstage/rugvip/noignore

remove usage of @ts-ignore

plugins/techdocs/src/client.test.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { Config } from '@backstage/config';
+import { MockConfigApi } from '@backstage/test-utils';
 import { UrlPatternDiscovery } from '@backstage/core-app-api';
 import { IdentityApi } from '@backstage/core-plugin-api';
 import { NotFoundError } from '@backstage/errors';
@@ -35,9 +35,11 @@ const mockEntity = {
 
 describe('TechDocsStorageClient', () => {
   const mockBaseUrl = 'http://backstage:9191/api/techdocs';
-  const configApi = {
-    getOptionalString: () => 'http://backstage:9191/api/techdocs',
-  } as Partial<Config>;
+  const configApi = new MockConfigApi({
+    techdocs: {
+      requestUrl: 'http://backstage:9191/api/techdocs',
+    },
+  });
   const discoveryApi = UrlPatternDiscovery.compile(mockBaseUrl);
   const identityApi: jest.Mocked<IdentityApi> = {
     signOut: jest.fn(),
@@ -52,8 +54,11 @@ describe('TechDocsStorageClient', () => {
   });
 
   it('should return correct base url based on defined storage', async () => {
-    // @ts-ignore Partial<Config> not assignable to Config.
-    const storageApi = new TechDocsStorageClient({ configApi, discoveryApi });
+    const storageApi = new TechDocsStorageClient({
+      configApi,
+      discoveryApi,
+      identityApi,
+    });
 
     await expect(
       storageApi.getBaseUrl('test.js', mockEntity, ''),
@@ -69,8 +74,11 @@ describe('TechDocsStorageClient', () => {
   });
 
   it('should return base url with correct entity structure', async () => {
-    // @ts-ignore Partial<Config> not assignable to Config.
-    const storageApi = new TechDocsStorageClient({ configApi, discoveryApi });
+    const storageApi = new TechDocsStorageClient({
+      configApi,
+      discoveryApi,
+      identityApi,
+    });
 
     await expect(
       storageApi.getBaseUrl('test/', mockEntity, ''),
@@ -82,7 +90,6 @@ describe('TechDocsStorageClient', () => {
   describe('syncEntityDocs', () => {
     it('should create eventsource without headers', async () => {
       const storageApi = new TechDocsStorageClient({
-        // @ts-ignore Partial<Config> not assignable to Config.
         configApi,
         discoveryApi,
         identityApi,
@@ -106,7 +113,6 @@ describe('TechDocsStorageClient', () => {
 
     it('should create eventsource with headers', async () => {
       const storageApi = new TechDocsStorageClient({
-        // @ts-ignore Partial<Config> not assignable to Config.
         configApi,
         discoveryApi,
         identityApi,
@@ -132,7 +138,6 @@ describe('TechDocsStorageClient', () => {
 
     it('should resolve to cached', async () => {
       const storageApi = new TechDocsStorageClient({
-        // @ts-ignore Partial<Config> not assignable to Config.
         configApi,
         discoveryApi,
         identityApi,
@@ -153,7 +158,6 @@ describe('TechDocsStorageClient', () => {
 
     it('should resolve to updated', async () => {
       const storageApi = new TechDocsStorageClient({
-        // @ts-ignore Partial<Config> not assignable to Config.
         configApi,
         discoveryApi,
         identityApi,
@@ -174,7 +178,6 @@ describe('TechDocsStorageClient', () => {
 
     it('should log values', async () => {
       const storageApi = new TechDocsStorageClient({
-        // @ts-ignore Partial<Config> not assignable to Config.
         configApi,
         discoveryApi,
         identityApi,
@@ -203,7 +206,6 @@ describe('TechDocsStorageClient', () => {
 
     it('should throw NotFoundError', async () => {
       const storageApi = new TechDocsStorageClient({
-        // @ts-ignore Partial<Config> not assignable to Config.
         configApi,
         discoveryApi,
         identityApi,
@@ -229,7 +231,6 @@ describe('TechDocsStorageClient', () => {
 
     it('should throw generic errors', async () => {
       const storageApi = new TechDocsStorageClient({
-        // @ts-ignore Partial<Config> not assignable to Config.
         configApi,
         discoveryApi,
         identityApi,