fix: Flip templateFilter to match Array.filter

Signed-off-by: Jack Palmer <jackpalmer@spotify.com>

plugins/scaffolder/src/components/TemplateList/TemplateList.test.tsx

@@ -77,7 +77,7 @@ describe('TemplateList', () => {
       { mountedRoutes: { '/': rootRouteRef } },
     );
 
-    expect(() => screen.getByTestId('t1')).toThrow();
-    expect(screen.getByTestId('t2')).toBeDefined();
+    expect(() => screen.getByTestId('t2')).toThrow();
+    expect(screen.getByTestId('t1')).toBeDefined();
   });
 });

plugins/scaffolder/src/components/TemplateList/TemplateList.tsx

@@ -59,7 +59,7 @@ export const TemplateList = ({
   const templateEntities = entities.filter(isTemplateEntityV1beta3);
   const maybeFilteredEntities = (
     group ? templateEntities.filter(group.filter) : templateEntities
-  ).filter(e => (templateFilter ? !templateFilter(e) : true));
+  ).filter(e => (templateFilter ? templateFilter(e) : true));
 
   const titleComponent: React.ReactNode = (() => {
     if (group && group.title) {