From a6318cedcc5bb14ea89278a011099cd00932fc55 Mon Sep 17 00:00:00 2001 From: Hamza El Aoutar Date: Wed, 27 Apr 2022 15:05:19 +0000 Subject: [PATCH] Added changeset Signed-off-by: Hamza El Aoutar --- .changeset/witty-readers-give.md | 5 +++++ .../core-components/src/components/Link/Link.tsx | 12 ++++++------ 2 files changed, 11 insertions(+), 6 deletions(-) create mode 100644 .changeset/witty-readers-give.md diff --git a/.changeset/witty-readers-give.md b/.changeset/witty-readers-give.md new file mode 100644 index 0000000000..87d19fc281 --- /dev/null +++ b/.changeset/witty-readers-give.md @@ -0,0 +1,5 @@ +--- +'@backstage/core-components': minor +--- + +Announce external links to screen readers diff --git a/packages/core-components/src/components/Link/Link.tsx b/packages/core-components/src/components/Link/Link.tsx index 2b711930a7..d1b9e2b7db 100644 --- a/packages/core-components/src/components/Link/Link.tsx +++ b/packages/core-components/src/components/Link/Link.tsx @@ -28,13 +28,13 @@ import { const useStyles = makeStyles( { visuallyHidden: { - top: 0, + clip: 'rect(0 0 0 0)', + clipPath: 'inset(50%)', + overflow: 'hidden', position: 'absolute', - zIndex: 1000, - transform: 'translateY(-200%)', - '&:focus': { - transform: 'translateY(5px)', - }, + whiteSpace: 'nowrap', + height: 1, + width: 1, }, }, { name: 'Link' },