+2
-2
@@ -117,7 +117,7 @@ export class JsonRulesEngineFactChecker
|
||||
if (hasAllFacts) {
|
||||
engine.addRule({ ...techInsightCheck.rule, event: noopEvent });
|
||||
} else {
|
||||
this.logger.warn(
|
||||
this.logger.debug(
|
||||
`Skipping ${
|
||||
rule.name
|
||||
} due to missing facts: ${techInsightCheck.factIds
|
||||
@@ -138,7 +138,7 @@ export class JsonRulesEngineFactChecker
|
||||
techInsightChecks,
|
||||
Object.values(facts),
|
||||
);
|
||||
} catch (e) {
|
||||
} catch (e: any) {
|
||||
throw new Error(`Failed to run rules engine, ${e.message}`);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -27,6 +27,7 @@ import { Logger } from 'winston';
|
||||
import { DateTime } from 'luxon';
|
||||
import { PersistenceContext } from './persistence/persistenceContext';
|
||||
import {
|
||||
EntityName,
|
||||
EntityRef,
|
||||
parseEntityName,
|
||||
stringifyEntityRef,
|
||||
@@ -96,7 +97,29 @@ export async function createRouter<
|
||||
const entityTriplet = stringifyEntityRef({ namespace, kind, name });
|
||||
const checkResult = await factChecker.runChecks(entityTriplet, checks);
|
||||
return res.send(checkResult);
|
||||
} catch (e) {
|
||||
} catch (e: any) {
|
||||
return res.status(500).json({ message: e.message }).send();
|
||||
}
|
||||
});
|
||||
|
||||
router.post('/checks/run', async (req, res) => {
|
||||
try {
|
||||
const {
|
||||
checks,
|
||||
entities,
|
||||
}: { checks: string[]; entities: EntityName[] } = req.body;
|
||||
const tasks = entities.map(async entity => {
|
||||
const entityTriplet =
|
||||
typeof entity === 'string' ? entity : stringifyEntityRef(entity);
|
||||
const results = await factChecker.runChecks(entityTriplet, checks);
|
||||
return {
|
||||
entity: entityTriplet,
|
||||
results,
|
||||
};
|
||||
});
|
||||
const results = await Promise.all(tasks);
|
||||
return res.send(results);
|
||||
} catch (e: any) {
|
||||
return res.status(500).json({ message: e.message }).send();
|
||||
}
|
||||
});
|
||||
|
||||
@@ -12,6 +12,12 @@ export interface BooleanCheckResult extends CheckResult {
|
||||
result: boolean;
|
||||
}
|
||||
|
||||
// @public
|
||||
export type BulkCheckResponse = Array<{
|
||||
entity: string;
|
||||
results: CheckResult[];
|
||||
}>;
|
||||
|
||||
// @public
|
||||
export interface CheckResponse {
|
||||
description: string;
|
||||
|
||||
@@ -124,3 +124,13 @@ export type CheckResult = {
|
||||
export interface BooleanCheckResult extends CheckResult {
|
||||
result: boolean;
|
||||
}
|
||||
|
||||
/**
|
||||
* Response type for bulk check opretation. Contains a list of entities and their respective check results.
|
||||
*
|
||||
* @public
|
||||
*/
|
||||
export type BulkCheckResponse = Array<{
|
||||
entity: string;
|
||||
results: CheckResult[];
|
||||
}>;
|
||||
|
||||
@@ -7,6 +7,7 @@
|
||||
|
||||
import { ApiRef } from '@backstage/core-plugin-api';
|
||||
import { BackstagePlugin } from '@backstage/core-plugin-api';
|
||||
import { BulkCheckResponse } from '@backstage/plugin-tech-insights-common';
|
||||
import { CheckResult } from '@backstage/plugin-tech-insights-common';
|
||||
import { EntityName } from '@backstage/catalog-model';
|
||||
import { default as React_2 } from 'react';
|
||||
@@ -50,6 +51,11 @@ export interface TechInsightsApi {
|
||||
description?: string,
|
||||
) => CheckResultRenderer | undefined;
|
||||
// (undocumented)
|
||||
runBulkChecks(
|
||||
entities: EntityName[],
|
||||
checks?: Check[],
|
||||
): Promise<BulkCheckResponse>;
|
||||
// (undocumented)
|
||||
runChecks(entityParams: EntityName, checks?: Check[]): Promise<CheckResult[]>;
|
||||
}
|
||||
|
||||
|
||||
@@ -15,7 +15,10 @@
|
||||
*/
|
||||
|
||||
import { createApiRef } from '@backstage/core-plugin-api';
|
||||
import { CheckResult } from '@backstage/plugin-tech-insights-common';
|
||||
import {
|
||||
CheckResult,
|
||||
BulkCheckResponse,
|
||||
} from '@backstage/plugin-tech-insights-common';
|
||||
import { Check } from './types';
|
||||
import { CheckResultRenderer } from '../components/CheckResultRenderer';
|
||||
import { EntityName } from '@backstage/catalog-model';
|
||||
@@ -43,4 +46,8 @@ export interface TechInsightsApi {
|
||||
) => CheckResultRenderer | undefined;
|
||||
getAllChecks(): Promise<Check[]>;
|
||||
runChecks(entityParams: EntityName, checks?: Check[]): Promise<CheckResult[]>;
|
||||
runBulkChecks(
|
||||
entities: EntityName[],
|
||||
checks?: Check[],
|
||||
): Promise<BulkCheckResponse>;
|
||||
}
|
||||
|
||||
@@ -15,7 +15,10 @@
|
||||
*/
|
||||
|
||||
import { TechInsightsApi } from './TechInsightsApi';
|
||||
import { CheckResult } from '@backstage/plugin-tech-insights-common';
|
||||
import {
|
||||
BulkCheckResponse,
|
||||
CheckResult,
|
||||
} from '@backstage/plugin-tech-insights-common';
|
||||
import { Check } from './types';
|
||||
import { DiscoveryApi, IdentityApi } from '@backstage/core-plugin-api';
|
||||
import { ResponseError } from '@backstage/errors';
|
||||
@@ -97,4 +100,29 @@ export class TechInsightsClient implements TechInsightsApi {
|
||||
}
|
||||
return await response.json();
|
||||
}
|
||||
|
||||
async runBulkChecks(
|
||||
entities: EntityName[],
|
||||
checks?: Check[],
|
||||
): Promise<BulkCheckResponse> {
|
||||
const url = await this.discoveryApi.getBaseUrl('tech-insights');
|
||||
const token = await this.identityApi.getIdToken();
|
||||
const checkIds = checks ? checks.map(check => check.id) : [];
|
||||
const requestBody = {
|
||||
entities,
|
||||
checks: checkIds.length > 0 ? checkIds : undefined,
|
||||
};
|
||||
const response = await fetch(`${url}/checks/run`, {
|
||||
method: 'POST',
|
||||
body: JSON.stringify(requestBody),
|
||||
headers: {
|
||||
'Content-Type': 'application/json',
|
||||
...(token && { Authorization: `Bearer ${token}` }),
|
||||
},
|
||||
});
|
||||
if (!response.ok) {
|
||||
throw await ResponseError.fromResponse(response);
|
||||
}
|
||||
return await response.json();
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user