From 12821e4832d9b267e62b7d909ed40c7f5bc8c226 Mon Sep 17 00:00:00 2001 From: Bruno Cascio Date: Wed, 4 Oct 2023 16:04:35 -0300 Subject: [PATCH 1/3] fix newrelic dashboard key prop on list Signed-off-by: Bruno Cascio --- .../src/components/NewRelicDashboard/DashboardEntityList.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/newrelic-dashboard/src/components/NewRelicDashboard/DashboardEntityList.tsx b/plugins/newrelic-dashboard/src/components/NewRelicDashboard/DashboardEntityList.tsx index 6c89f3eb80..8d87a54ca0 100644 --- a/plugins/newrelic-dashboard/src/components/NewRelicDashboard/DashboardEntityList.tsx +++ b/plugins/newrelic-dashboard/src/components/NewRelicDashboard/DashboardEntityList.tsx @@ -69,9 +69,9 @@ export const DashboardEntityList = () => { <>No Dashboard Pages found with the specified Dashboard GUID )} {value?.getDashboardEntity?.data.actor.entitySearch.results.entities?.map( - (entityResult: ResultEntity) => { + (entityResult: ResultEntity, index: number) => { return ( - + From 5194a51a1c0c0d8b971ea9947ce2938d423b1080 Mon Sep 17 00:00:00 2001 From: Bruno Cascio Date: Wed, 4 Oct 2023 18:03:02 -0300 Subject: [PATCH 2/3] added changeset Signed-off-by: Bruno Cascio --- .changeset/violet-apes-beam.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/violet-apes-beam.md diff --git a/.changeset/violet-apes-beam.md b/.changeset/violet-apes-beam.md new file mode 100644 index 0000000000..a077893d07 --- /dev/null +++ b/.changeset/violet-apes-beam.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-newrelic-dashboard': patch +--- + +fixed required react propery "key" looping the dashboards From 3dd429c29d057d7f3d8d93ec600c56585014f79b Mon Sep 17 00:00:00 2001 From: Bruno Cascio Date: Sat, 7 Oct 2023 22:16:51 -0300 Subject: [PATCH 3/3] fix .changeset Co-authored-by: Vincenzo Scamporlino Signed-off-by: Bruno Cascio --- .changeset/violet-apes-beam.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/violet-apes-beam.md b/.changeset/violet-apes-beam.md index a077893d07..544dcf72b2 100644 --- a/.changeset/violet-apes-beam.md +++ b/.changeset/violet-apes-beam.md @@ -2,4 +2,4 @@ '@backstage/plugin-newrelic-dashboard': patch --- -fixed required react propery "key" looping the dashboards +Fixed React Warning: "Each child in a list should have a unique 'key' prop" during the rendering of `EntityNewRelicDashboardCard`