diff --git a/.changeset/tender-feet-draw.md b/.changeset/tender-feet-draw.md new file mode 100644 index 0000000000..435d80ebd6 --- /dev/null +++ b/.changeset/tender-feet-draw.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-techdocs': patch +--- + +Added title prop to OffsetPaginatedDocsTable for proper display diff --git a/plugins/techdocs/src/home/components/Tables/OffsetPaginatedDocsTable.test.tsx b/plugins/techdocs/src/home/components/Tables/OffsetPaginatedDocsTable.test.tsx index 6b75fa7aee..beeae2a957 100644 --- a/plugins/techdocs/src/home/components/Tables/OffsetPaginatedDocsTable.test.tsx +++ b/plugins/techdocs/src/home/components/Tables/OffsetPaginatedDocsTable.test.tsx @@ -52,6 +52,8 @@ describe('OffsetPaginatedDocsTable', () => { }, ]; + const tableTitle = 'All Docs'; + const wrapInContext = ( node: ReactNode, value?: Partial>, @@ -66,7 +68,11 @@ describe('OffsetPaginatedDocsTable', () => { it('should display all the items', async () => { await renderInTestApp( wrapInContext( - , + , { setOffset: jest.fn(), limit: Number.MAX_SAFE_INTEGER, @@ -76,6 +82,8 @@ describe('OffsetPaginatedDocsTable', () => { ), ); + expect(screen.getByText(tableTitle)).toBeInTheDocument(); + for (const item of data) { expect(screen.queryByText(item.entity.metadata.name)).toBeInTheDocument(); } diff --git a/plugins/techdocs/src/home/components/Tables/OffsetPaginatedDocsTable.tsx b/plugins/techdocs/src/home/components/Tables/OffsetPaginatedDocsTable.tsx index c287bc3d94..5de84bfe03 100644 --- a/plugins/techdocs/src/home/components/Tables/OffsetPaginatedDocsTable.tsx +++ b/plugins/techdocs/src/home/components/Tables/OffsetPaginatedDocsTable.tsx @@ -27,7 +27,7 @@ import { * @internal */ export function OffsetPaginatedDocsTable(props: TableProps) { - const { actions, columns, data, isLoading, options } = props; + const { actions, columns, data, isLoading, options, title } = props; const { updateFilters, setLimit, setOffset, limit, totalItems, offset } = useEntityList(); const [page, setPage] = useState( @@ -44,6 +44,7 @@ export function OffsetPaginatedDocsTable(props: TableProps) { return ( + title={title} columns={columns} data={data} options={{