paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 43 Packages Projects Releases Wiki Activity

fix: use Material UI vs. MUI where relevant

Browse Source 
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
This commit is contained in:
Olivier Tassinari
2023-07-04 23:22:34 +02:00
parent b5344d21db
commit a51fb51617
57 changed files with 156 additions and 153 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/tutorials/migrating-away-from-core.md
+2 -2
View File
@@ -128,11 +128,11 @@ old usages by the `string` type.
### Constrained `IconComponent` type
The `IconComponent` type used to allow all of the props from the MUI `SvgIcon`.
The `IconComponent` type used to allow all of the props from the Material UI `SvgIcon`.
This encouraged some bad patterns in open source plugins such as applying colors
to the icons, which in turn hurt the ability to replace the icons with custom
ones. The `IconComponent` type, which is now exported from
`@backstage/core-plugin-api`, now only accepts a `fontSize` prop used to set the
size of the icon. The type is compatible with the MUI `SvgIcon`, but there may
size of the icon. The type is compatible with the Material UI `SvgIcon`, but there may
be situations where an icon needs an explicit cast to `IconComponent` in order
to narrow the type.