From a4c05f203fd2dd8006ea1deeb4e3fbecb218ff1f Mon Sep 17 00:00:00 2001
From: Bilawal Hameed <bil@spotify.com>
Date: Sat, 2 May 2020 14:40:31 +0200
Subject: [PATCH] fix: updated tests for RadarPage and RadarComponent

---
 .../src/components/RadarComponent.test.tsx    | 102 ++++++++++++++++++
 .../src/components/RadarPage.test.tsx         |  20 +++-
 2 files changed, 117 insertions(+), 5 deletions(-)
 create mode 100644 plugins/tech-radar/src/components/RadarComponent.test.tsx

diff --git a/plugins/tech-radar/src/components/RadarComponent.test.tsx b/plugins/tech-radar/src/components/RadarComponent.test.tsx
new file mode 100644
index 0000000000..2f3fcff198
--- /dev/null
+++ b/plugins/tech-radar/src/components/RadarComponent.test.tsx
@@ -0,0 +1,102 @@
+/*
+ * Copyright 2020 Spotify AB
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import React from 'react';
+import { render, waitForElement } from '@testing-library/react';
+import { ThemeProvider } from '@material-ui/core';
+import { lightTheme } from '@backstage/theme';
+import { ApiRegistry, ApiProvider, errorApiRef } from '@backstage/core';
+import { withLogCollector } from '@backstage/test-utils-core';
+
+import GetBBoxPolyfill from '../utils/polyfills/getBBox';
+import RadarComponent from './RadarComponent';
+
+describe('RadarComponent', () => {
+  beforeAll(() => {
+    GetBBoxPolyfill.create(0, 0, 1000, 500);
+  });
+
+  afterAll(() => {
+    GetBBoxPolyfill.remove();
+  });
+
+  it('should render a progress bar', async () => {
+    const errorApi = { post: () => {} };
+
+    const { getByTestId, queryByTestId } = render(
+      <ThemeProvider theme={lightTheme}>
+        <ApiProvider apis={ApiRegistry.from([[errorApiRef, errorApi]])}>
+          <RadarComponent
+            width={1200}
+            height={800}
+            svgProps={{ 'data-testid': 'tech-radar-svg' }}
+          />
+        </ApiProvider>
+      </ThemeProvider>,
+    );
+
+    expect(getByTestId('progress')).toBeInTheDocument();
+
+    await waitForElement(() => queryByTestId('tech-radar-svg'));
+  });
+
+  it('should call the errorApi if load fails', async () => {
+    const errorApi = { post: jest.fn() };
+    const techRadarLoadFail = () =>
+      Promise.reject(new Error('404 Page Not Found'));
+
+    const { queryByTestId } = render(
+      <ThemeProvider theme={lightTheme}>
+        <ApiProvider apis={ApiRegistry.from([[errorApiRef, errorApi]])}>
+          <RadarComponent
+            width={1200}
+            height={800}
+            getData={techRadarLoadFail}
+            svgProps={{ 'data-testid': 'tech-radar-svg' }}
+          />
+        </ApiProvider>
+      </ThemeProvider>,
+    );
+
+    await waitForElement(() => !queryByTestId('progress'));
+
+    expect(errorApi.post).toHaveBeenCalledTimes(1);
+    expect(errorApi.post).toHaveBeenCalledWith(new Error('404 Page Not Found'));
+    expect(queryByTestId('tech-radar-svg')).not.toBeInTheDocument();
+  });
+
+  it('should not render without errorApiRef', () => {
+    expect(
+      withLogCollector(['error'], () => {
+        expect(() => {
+          render(
+            <ThemeProvider theme={lightTheme}>
+              <ApiProvider apis={ApiRegistry.from([])}>
+                <RadarComponent
+                  width={1200}
+                  height={800}
+                  svgProps={{ 'data-testid': 'tech-radar-svg' }}
+                />
+              </ApiProvider>
+            </ThemeProvider>,
+          );
+        }).toThrow();
+      }).error[0],
+    ).toMatch(
+      /^Error: Uncaught \[Error: No implementation available for apiRef{core.error}\]/,
+    );
+  });
+});
diff --git a/plugins/tech-radar/src/components/RadarPage.test.tsx b/plugins/tech-radar/src/components/RadarPage.test.tsx
index 9913895949..5ef71d1693 100644
--- a/plugins/tech-radar/src/components/RadarPage.test.tsx
+++ b/plugins/tech-radar/src/components/RadarPage.test.tsx
@@ -22,7 +22,7 @@ import { ApiRegistry, ApiProvider, errorApiRef } from '@backstage/core';
 import { withLogCollector } from '@backstage/test-utils-core';
 
 import GetBBoxPolyfill from '../utils/polyfills/getBBox';
-import { techRadarApiRef, TechRadar, loadSampleData } from '../index';
+import { techRadarApiRef, TechRadar } from '../index';
 import RadarPage from './RadarPage';
 
 describe('RadarPage', () => {
@@ -36,7 +36,9 @@ describe('RadarPage', () => {
 
   it('should render a progress bar', async () => {
     const errorApi = { post: () => {} };
-    const techRadarApi = new TechRadar(1200, 800, loadSampleData, {
+    const techRadarApi = new TechRadar({
+      width: 1200,
+      height: 800,
       svgProps: { 'data-testid': 'tech-radar-svg' },
     });
 
@@ -60,7 +62,9 @@ describe('RadarPage', () => {
 
   it('should render a header with a svg', async () => {
     const errorApi = { post: () => {} };
-    const techRadarApi = new TechRadar(1200, 800, loadSampleData, {
+    const techRadarApi = new TechRadar({
+      width: 1200,
+      height: 800,
       svgProps: { 'data-testid': 'tech-radar-svg' },
     });
 
@@ -87,7 +91,10 @@ describe('RadarPage', () => {
     const errorApi = { post: jest.fn() };
     const techRadarLoadFail = () =>
       Promise.reject(new Error('404 Page Not Found'));
-    const techRadarApi = new TechRadar(1200, 800, techRadarLoadFail, {
+    const techRadarApi = new TechRadar({
+      width: 1200,
+      height: 800,
+      getData: techRadarLoadFail,
       svgProps: { 'data-testid': 'tech-radar-svg' },
     });
 
@@ -112,7 +119,10 @@ describe('RadarPage', () => {
   });
 
   it('should not render without errorApiRef', () => {
-    const techRadarApi = new TechRadar(1200, 800, loadSampleData);
+    const techRadarApi = new TechRadar({
+      width: 1200,
+      height: 800,
+    });
 
     expect(
       withLogCollector(['error'], () => {