From a45b01ddb97140927d895fdf65f420eb60b44c9b Mon Sep 17 00:00:00 2001
From: Camila Belo <camilaibs@gmail.com>
Date: Fri, 20 Sep 2024 10:49:29 +0200
Subject: [PATCH] refactor: apply review suggestions
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
---
 plugins/scaffolder/src/components/FileBrowser/FileBrowser.tsx  | 2 +-
 .../scaffolder/src/next/TemplateEditorPage/TemplateEditor.tsx  | 3 +--
 .../src/next/TemplateEditorPage/TemplateEditorToolbar.tsx      | 2 +-
 plugins/scaffolder/src/translation.ts                          | 2 +-
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/plugins/scaffolder/src/components/FileBrowser/FileBrowser.tsx b/plugins/scaffolder/src/components/FileBrowser/FileBrowser.tsx
index d18ac02d4e..9c5dc84249 100644
--- a/plugins/scaffolder/src/components/FileBrowser/FileBrowser.tsx
+++ b/plugins/scaffolder/src/components/FileBrowser/FileBrowser.tsx
@@ -25,7 +25,7 @@ const useStyles = makeStyles(theme => ({
   root: {
     whiteSpace: 'nowrap',
     overflowY: 'auto',
-    padding: theme.spacing(1.5),
+    padding: theme.spacing(1),
   },
 }));
 
diff --git a/plugins/scaffolder/src/next/TemplateEditorPage/TemplateEditor.tsx b/plugins/scaffolder/src/next/TemplateEditorPage/TemplateEditor.tsx
index 675f09a4d9..7a0f18c03c 100644
--- a/plugins/scaffolder/src/next/TemplateEditorPage/TemplateEditor.tsx
+++ b/plugins/scaffolder/src/next/TemplateEditorPage/TemplateEditor.tsx
@@ -44,7 +44,6 @@ const useStyles = makeStyles(
     root: {
       height: '100%',
       gridArea: 'pageContent',
-      height: '100%',
       display: 'grid',
       gridTemplateAreas: `
       "toolbar toolbar toolbar"
@@ -78,7 +77,7 @@ const useStyles = makeStyles(
       left: 0,
       right: 0,
       bottom: 0,
-      padding: theme.spacing(1.5),
+      padding: theme.spacing(1),
       overflow: 'auto',
     },
     results: {
diff --git a/plugins/scaffolder/src/next/TemplateEditorPage/TemplateEditorToolbar.tsx b/plugins/scaffolder/src/next/TemplateEditorPage/TemplateEditorToolbar.tsx
index 0f09f0a0ef..ef4ac95c3c 100644
--- a/plugins/scaffolder/src/next/TemplateEditorPage/TemplateEditorToolbar.tsx
+++ b/plugins/scaffolder/src/next/TemplateEditorPage/TemplateEditorToolbar.tsx
@@ -50,7 +50,7 @@ const useStyles = makeStyles(
     toolbar: {
       display: 'grid',
       justifyItems: 'flex-end',
-      padding: theme.spacing(0, 1.5),
+      padding: theme.spacing(0, 1),
       backgroundColor: theme.palette.background.paper,
     },
   }),
diff --git a/plugins/scaffolder/src/translation.ts b/plugins/scaffolder/src/translation.ts
index 6f45163f44..5af634a44e 100644
--- a/plugins/scaffolder/src/translation.ts
+++ b/plugins/scaffolder/src/translation.ts
@@ -186,7 +186,7 @@ export const scaffolderTranslationRef = createTranslationRef({
     },
     templateEditorForm: {
       stepper: {
-        emptyText: 'There is no spec parameters in the template to preview.',
+        emptyText: 'There are no spec parameters in the template to preview.',
       },
     },
     templateTypePicker: {