From a3ff3fba0396bc078e946fa9deb959fcfb440f2a Mon Sep 17 00:00:00 2001 From: Jonas Beck Date: Tue, 29 Jul 2025 16:34:18 +0200 Subject: [PATCH] chore(kafka): remove luxon dependency Signed-off-by: Jonas Beck --- plugins/events-backend-module-kafka/package.json | 3 +-- plugins/events-backend-module-kafka/src/publisher/config.ts | 4 ++-- yarn.lock | 1 - 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/plugins/events-backend-module-kafka/package.json b/plugins/events-backend-module-kafka/package.json index ed9a9383a7..f30a863002 100644 --- a/plugins/events-backend-module-kafka/package.json +++ b/plugins/events-backend-module-kafka/package.json @@ -39,8 +39,7 @@ "@backstage/config": "workspace:^", "@backstage/plugin-events-node": "workspace:^", "@backstage/types": "workspace:^", - "kafkajs": "^2.2.4", - "luxon": "^3.0.0" + "kafkajs": "^2.2.4" }, "devDependencies": { "@backstage/backend-test-utils": "workspace:^", diff --git a/plugins/events-backend-module-kafka/src/publisher/config.ts b/plugins/events-backend-module-kafka/src/publisher/config.ts index aa5921a7f3..69ede48d54 100644 --- a/plugins/events-backend-module-kafka/src/publisher/config.ts +++ b/plugins/events-backend-module-kafka/src/publisher/config.ts @@ -14,8 +14,8 @@ * limitations under the License. */ import { Config, readDurationFromConfig } from '@backstage/config'; +import { durationToMilliseconds } from '@backstage/types'; import { ConsumerConfig, ConsumerSubscribeTopics, KafkaConfig } from 'kafkajs'; -import { Duration } from 'luxon'; /** * @public @@ -54,7 +54,7 @@ const readOptionalHumanDurationInMs = ( if (!humanDuration) return undefined; - return Duration.fromObject(humanDuration).as('milliseconds'); + return durationToMilliseconds(humanDuration); }; export const readConfig = ( diff --git a/yarn.lock b/yarn.lock index 4621fdd8b8..f41135f82f 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6246,7 +6246,6 @@ __metadata: "@backstage/plugin-events-node": "workspace:^" "@backstage/types": "workspace:^" kafkajs: "npm:^2.2.4" - luxon: "npm:^3.0.0" languageName: unknown linkType: soft