From 5b2dd00f55312f944538c72424ea32c17f42b308 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Mon, 1 Feb 2021 21:51:03 -0500 Subject: [PATCH 1/4] Fix typos --- .../user-settings/src/components/FeatureFlags/EmptyFlags.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/user-settings/src/components/FeatureFlags/EmptyFlags.tsx b/plugins/user-settings/src/components/FeatureFlags/EmptyFlags.tsx index 5df4df4450..de6f4703e0 100644 --- a/plugins/user-settings/src/components/FeatureFlags/EmptyFlags.tsx +++ b/plugins/user-settings/src/components/FeatureFlags/EmptyFlags.tsx @@ -32,11 +32,11 @@ export const EmptyFlags = () => ( - An example how how to add a feature flags is highlighted below: + An example for how to add a feature flag is highlighted below: Date: Mon, 1 Feb 2021 21:51:32 -0500 Subject: [PATCH 2/4] Remove extraneous grid --- .../src/components/General/Profile.tsx | 42 +++++++++---------- 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/plugins/user-settings/src/components/General/Profile.tsx b/plugins/user-settings/src/components/General/Profile.tsx index b0231d95b6..c8034085bd 100644 --- a/plugins/user-settings/src/components/General/Profile.tsx +++ b/plugins/user-settings/src/components/General/Profile.tsx @@ -24,31 +24,27 @@ export const Profile = () => { const { profile, displayName } = useUserProfile(); return ( - - - - - - - - - - - - {displayName} - - - {profile.email} - - - - - - + + + + + + + + + + {displayName} + + + {profile.email} + - + + + + - + ); }; From c88aa5f04aa5b18cd60660cdd65db437abfddb15 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Mon, 1 Feb 2021 21:52:06 -0500 Subject: [PATCH 3/4] Keep PinButton visible --- plugins/user-settings/src/components/General/General.tsx | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/plugins/user-settings/src/components/General/General.tsx b/plugins/user-settings/src/components/General/General.tsx index 2d30c00eec..b5054217e4 100644 --- a/plugins/user-settings/src/components/General/General.tsx +++ b/plugins/user-settings/src/components/General/General.tsx @@ -14,15 +14,13 @@ * limitations under the License. */ import { InfoCard } from '@backstage/core'; -import { Grid, List, useMediaQuery, useTheme } from '@material-ui/core'; +import { Grid, List } from '@material-ui/core'; import React from 'react'; import { PinButton } from './PinButton'; import { Profile } from './Profile'; import { ThemeToggle } from './ThemeToggle'; export const General = () => { - const theme = useTheme(); - const fullScreen = useMediaQuery(theme.breakpoints.down('sm')); return ( @@ -32,7 +30,7 @@ export const General = () => { - {!fullScreen && } + From de98c32ed40d96c095f03f09867713e39cd3aef2 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Mon, 1 Feb 2021 21:53:37 -0500 Subject: [PATCH 4/4] Add changeset --- .changeset/tidy-news-perform.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/tidy-news-perform.md diff --git a/.changeset/tidy-news-perform.md b/.changeset/tidy-news-perform.md new file mode 100644 index 0000000000..055f051da7 --- /dev/null +++ b/.changeset/tidy-news-perform.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-user-settings': patch +--- + +Keep the Pin Sidebar setting visible on small screens.