From a22a9cbfddacfa97c2a8e118b9bed8e1d0f9f987 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Fri, 22 May 2020 15:26:27 +0200 Subject: [PATCH] packages/core: minor auth text fixes + reduntant has --- .../OAuthRequestManager/OAuthPendingRequests.ts | 4 +--- .../implementations/lib/AuthConnector/DefaultAuthConnector.ts | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/core/src/api/apis/implementations/OAuthRequestManager/OAuthPendingRequests.ts b/packages/core/src/api/apis/implementations/OAuthRequestManager/OAuthPendingRequests.ts index 6ee1674b39..aa5609b1e9 100644 --- a/packages/core/src/api/apis/implementations/OAuthRequestManager/OAuthPendingRequests.ts +++ b/packages/core/src/api/apis/implementations/OAuthRequestManager/OAuthPendingRequests.ts @@ -49,9 +49,7 @@ export function joinScopes( for (const moreScopes of moreScopess) { for (const scope of moreScopes) { - if (!result.has(scope)) { - result.add(scope); - } + result.add(scope); } } diff --git a/packages/core/src/api/apis/implementations/lib/AuthConnector/DefaultAuthConnector.ts b/packages/core/src/api/apis/implementations/lib/AuthConnector/DefaultAuthConnector.ts index 12a2118a42..161015b1a8 100644 --- a/packages/core/src/api/apis/implementations/lib/AuthConnector/DefaultAuthConnector.ts +++ b/packages/core/src/api/apis/implementations/lib/AuthConnector/DefaultAuthConnector.ts @@ -40,11 +40,11 @@ type Options = { */ provider: AuthProvider & { id: string }; /** - * API used to instanciate an auth requester. + * API used to instantiate an auth requester. */ oauthRequestApi: OAuthRequestApi; /** - * Function used to join together a set of scopes, defaults to joining with whitespace. + * Function used to join together a set of scopes, defaults to joining with a space character. */ joinScopes?: (scopes: Set) => string; /**