address PR comments

Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>

plugins/techdocs/src/client.ts

@@ -126,6 +126,8 @@ export class TechDocsStorageClient implements TechDocsStorageApi {
     configApi: Config;
     discoveryApi: DiscoveryApi;
     fetchApi: FetchApi;
+    // @deprecated Remove identityApiRef
+    identityApi?: any;
   }) {
     this.configApi = options.configApi;
     this.discoveryApi = options.discoveryApi;
@@ -212,7 +214,9 @@ export class TechDocsStorageClient implements TechDocsStorageApi {
         fetch: this.fetchApi.fetch,
         onmessage(e: any) {
           if (e.event === 'log') {
-            logHandler(JSON.parse(e.data));
+            if (e.data) {
+              logHandler(JSON.parse(e.data));
+            }
           } else if (e.event === 'finish') {
             let updated: boolean = false;
             if (e.data) {

plugins/techdocs/src/plugin.ts

@@ -31,6 +31,7 @@ import {
   createRoutableExtension,
   discoveryApiRef,
   fetchApiRef,
+  identityApiRef,
 } from '@backstage/core-plugin-api';
 import {
   createSearchResultListItemExtension,
@@ -51,13 +52,18 @@ export const techdocsPlugin = createPlugin({
       deps: {
         configApi: configApiRef,
         discoveryApi: discoveryApiRef,
+        /**
+         * @deprecated fetchApi is enough
+         */
+        identityApi: identityApiRef,
         fetchApi: fetchApiRef,
       },
-      factory: ({ configApi, discoveryApi, fetchApi }) =>
+      factory: ({ configApi, discoveryApi, fetchApi, identityApi = null }) =>
         new TechDocsStorageClient({
           configApi,
           discoveryApi,
           fetchApi,
+          identityApi,
         }),
     }),
     createApiFactory({