Typos CLI - initial config and changes

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Fixed test typos

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Fixed docs typos

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Fixed code comment typos

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Fixed remaining typos

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Added CI and Config

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Fixed typo, lol

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Fixes and update API reports

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Updated based on feedback

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Updated test

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Minor corrections

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Removed changesets

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Refactor to make changes non-breaking

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Clean up of new typos

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Use typoed over typo'd

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Added typoed

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Updated API Reports

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Feedback improvement

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Refinements

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Simplify based on feedback

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Reverted to handle both keys

Signed-off-by: Andre Wanlin <awanlin@spotify.com>
This commit is contained in:
Andre Wanlin
2026-03-02 09:26:47 -06:00
parent f0f6823a66
commit a07e6a31a4
29 changed files with 186 additions and 55 deletions
@@ -39,7 +39,7 @@ import { AwsCodeCommitIntegrationConfig } from './awsCodeCommit';
import { HarnessIntegration, HarnessIntegrationConfig } from './harness';
import {
AzureBlobStorageIntegrationConfig,
AzureBlobStorageIntergation,
AzureBlobStorageIntegration,
} from './azureBlobStorage';
import { GoogleGcsIntegration, GoogleGcsIntegrationConfig } from './googleGcs';
@@ -56,7 +56,7 @@ describe('ScmIntegrations', () => {
host: 'azure.local',
} as AzureIntegrationConfig);
const azureBlob = new AzureBlobStorageIntergation({
const azureBlob = new AzureBlobStorageIntegration({
host: 'azureblobstorage.local',
} as AzureBlobStorageIntegrationConfig);
+4 -4
View File
@@ -28,7 +28,7 @@ import { ScmIntegration, ScmIntegrationsGroup } from './types';
import { ScmIntegrationRegistry } from './registry';
import { GiteaIntegration } from './gitea';
import { HarnessIntegration } from './harness/HarnessIntegration';
import { AzureBlobStorageIntergation } from './azureBlobStorage';
import { AzureBlobStorageIntegration } from './azureBlobStorage';
import { GoogleGcsIntegration } from './googleGcs/GoogleGcsIntegration';
/**
@@ -39,7 +39,7 @@ import { GoogleGcsIntegration } from './googleGcs/GoogleGcsIntegration';
export interface IntegrationsByType {
awsS3: ScmIntegrationsGroup<AwsS3Integration>;
awsCodeCommit: ScmIntegrationsGroup<AwsCodeCommitIntegration>;
azureBlobStorage: ScmIntegrationsGroup<AzureBlobStorageIntergation>;
azureBlobStorage: ScmIntegrationsGroup<AzureBlobStorageIntegration>;
azure: ScmIntegrationsGroup<AzureIntegration>;
bitbucketCloud: ScmIntegrationsGroup<BitbucketCloudIntegration>;
bitbucketServer: ScmIntegrationsGroup<BitbucketServerIntegration>;
@@ -63,7 +63,7 @@ export class ScmIntegrations implements ScmIntegrationRegistry {
return new ScmIntegrations({
awsS3: AwsS3Integration.factory({ config }),
awsCodeCommit: AwsCodeCommitIntegration.factory({ config }),
azureBlobStorage: AzureBlobStorageIntergation.factory({ config }),
azureBlobStorage: AzureBlobStorageIntegration.factory({ config }),
azure: AzureIntegration.factory({ config }),
bitbucketCloud: BitbucketCloudIntegration.factory({ config }),
bitbucketServer: BitbucketServerIntegration.factory({ config }),
@@ -88,7 +88,7 @@ export class ScmIntegrations implements ScmIntegrationRegistry {
return this.byType.awsCodeCommit;
}
get azureBlobStorage(): ScmIntegrationsGroup<AzureBlobStorageIntergation> {
get azureBlobStorage(): ScmIntegrationsGroup<AzureBlobStorageIntegration> {
return this.byType.azureBlobStorage;
}
@@ -15,11 +15,11 @@
*/
import { ConfigReader } from '@backstage/config';
import { AzureBlobStorageIntergation } from './AzureBlobStorageIntegration';
import { AzureBlobStorageIntegration } from './AzureBlobStorageIntegration';
describe('AzureBlobStorageIntegration', () => {
it('has a working factory', () => {
const integrations = AzureBlobStorageIntergation.factory({
const integrations = AzureBlobStorageIntegration.factory({
config: new ConfigReader({
integrations: {
azureBlobStorage: [
@@ -40,7 +40,7 @@ describe('AzureBlobStorageIntegration', () => {
});
it('returns the basics', () => {
const integration = new AzureBlobStorageIntergation({
const integration = new AzureBlobStorageIntegration({
host: 'myaccount.blob.core.windows.net',
} as any);
expect(integration.type).toBe('azureBlobStorage');
@@ -49,7 +49,7 @@ describe('AzureBlobStorageIntegration', () => {
describe('resolveUrl', () => {
it('works for valid URLs', () => {
const integration = new AzureBlobStorageIntergation({
const integration = new AzureBlobStorageIntegration({
host: 'blob.core.windows.net',
} as any);
@@ -63,7 +63,7 @@ describe('AzureBlobStorageIntegration', () => {
});
it('resolve edit URL', () => {
const integration = new AzureBlobStorageIntergation({
const integration = new AzureBlobStorageIntegration({
host: 'myaccount.blob.core.windows.net',
} as any);
@@ -26,15 +26,15 @@ import {
*
* @public
*/
export class AzureBlobStorageIntergation implements ScmIntegration {
static factory: ScmIntegrationsFactory<AzureBlobStorageIntergation> = ({
export class AzureBlobStorageIntegration implements ScmIntegration {
static factory: ScmIntegrationsFactory<AzureBlobStorageIntegration> = ({
config,
}) => {
const configs = readAzureBlobStorageIntegrationConfigs(
config.getOptionalConfigArray('integrations.azureBlobStorage') ?? [],
);
return basicIntegrations(
configs.map(c => new AzureBlobStorageIntergation(c)),
configs.map(c => new AzureBlobStorageIntegration(c)),
i => i.config.host,
);
};
@@ -69,3 +69,20 @@ export class AzureBlobStorageIntergation implements ScmIntegration {
return url;
}
}
/**
* Microsoft Azure Blob storage based integration.
*
* @public
* @deprecated Use {@link AzureBlobStorageIntegration} instead. This was a typo in the original class name.
*/
export const AzureBlobStorageIntergation = AzureBlobStorageIntegration;
/**
* Microsoft Azure Blob storage based integration.
*
* @public
* @deprecated Use {@link AzureBlobStorageIntegration} instead. This was a typo in the original class name.
*/
// eslint-disable-next-line @typescript-eslint/no-redeclare
export type AzureBlobStorageIntergation = AzureBlobStorageIntegration;
@@ -13,7 +13,10 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
export { AzureBlobStorageIntergation } from './AzureBlobStorageIntegration';
export {
AzureBlobStorageIntegration,
AzureBlobStorageIntergation,
} from './AzureBlobStorageIntegration';
export {
readAzureBlobStorageIntegrationConfig,
readAzureBlobStorageIntegrationConfigs,
@@ -496,7 +496,7 @@ describe('parseRetryAfterMs', () => {
expect(parseRetryAfterMs(pastDate, 5000)).toBe(0);
});
it('returns fallback for null or unparseable values', () => {
it('returns fallback for null or unparsable values', () => {
expect(parseRetryAfterMs(null, 5000)).toBe(5000);
expect(parseRetryAfterMs('', 5000)).toBe(5000);
expect(parseRetryAfterMs('not-a-date-or-number', 5000)).toBe(5000);
+2 -2
View File
@@ -25,7 +25,7 @@ import { GithubIntegration } from './github/GithubIntegration';
import { GitLabIntegration } from './gitlab/GitLabIntegration';
import { GiteaIntegration } from './gitea/GiteaIntegration';
import { HarnessIntegration } from './harness/HarnessIntegration';
import { AzureBlobStorageIntergation } from './azureBlobStorage';
import { AzureBlobStorageIntegration } from './azureBlobStorage';
/**
* Holds all registered SCM integrations, of all types.
@@ -36,7 +36,7 @@ export interface ScmIntegrationRegistry
extends ScmIntegrationsGroup<ScmIntegration> {
awsS3: ScmIntegrationsGroup<AwsS3Integration>;
awsCodeCommit: ScmIntegrationsGroup<AwsCodeCommitIntegration>;
azureBlobStorage: ScmIntegrationsGroup<AzureBlobStorageIntergation>;
azureBlobStorage: ScmIntegrationsGroup<AzureBlobStorageIntegration>;
azure: ScmIntegrationsGroup<AzureIntegration>;
bitbucketCloud: ScmIntegrationsGroup<BitbucketCloudIntegration>;
bitbucketServer: ScmIntegrationsGroup<BitbucketServerIntegration>;