Merge pull request #4941 from erdoganoksuz/bug-fix/locale-case

use local version of all case conversion methods
This commit is contained in:
Fredrik Adelöw
2021-03-17 23:34:09 +01:00
committed by GitHub
31 changed files with 85 additions and 45 deletions
@@ -100,7 +100,9 @@ describe('Results Filter', () => {
);
for (const category of categories) {
expect(
await findByText(category.charAt(0).toUpperCase() + category.slice(1)),
await findByText(
category.charAt(0).toLocaleUpperCase('en-US') + category.slice(1),
),
).toBeInTheDocument();
}
});
@@ -107,7 +107,10 @@ export const ResultsFilter = ({ availableCategories }: Props) => {
/>
<ListItemText
id={labelId}
primary={category.charAt(0).toUpperCase() + category.slice(1)}
primary={
category.charAt(0).toLocaleUpperCase('en-US') +
category.slice(1)
}
/>
</ListItem>
);
@@ -105,8 +105,8 @@ export const ScaffolderPageContents = () => {
);
const matchesQuery = (metadata: EntityMeta, query: string) =>
`${metadata.title}`.toUpperCase().includes(query) ||
metadata.tags?.join('').toUpperCase().indexOf(query) !== -1;
`${metadata.title}`.toLocaleUpperCase('en-US').includes(query) ||
metadata.tags?.join('').toLocaleUpperCase('en-US').indexOf(query) !== -1;
useEffect(() => {
if (search.length === 0) {
@@ -114,7 +114,7 @@ export const ScaffolderPageContents = () => {
}
return setMatchingEntities(
filteredEntities.filter(template =>
matchesQuery(template.metadata, search.toUpperCase()),
matchesQuery(template.metadata, search.toLocaleUpperCase('en-US')),
),
);
}, [search, filteredEntities]);